1387456 - square photon tabs have a single pixel of space to the left of first tab

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Screenshot 2017-08-04 10.24.58.png

With the new photon tabs I noticed there is a sliver of space to the left of the first tab.  Obviously pretty minor, but I thought I would file in case this was not intentional.

See attached screenshot.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I noticed this when the window was maximized on win10.  Obviously the grab bar space when not maximized hides this otherwise.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1387456 - Remove the first tab's start border when the window is maximized/fullscreen.

Review commit: https://reviewboard.mozilla.org/r/166174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166174/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8895046 [details]
Bug 1387456 - Remove the first tab's start border when the window is maximized/fullscreen.

https://reviewboard.mozilla.org/r/166174/#review171710

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d973cec5aa53
Remove the first tab's start border when the window is maximized/fullscreen. r=johannh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d973cec5aa53

Comment 6

[Sajedul Islam]

I have reproduced this bug with Nightly 57.0a1 (2017-08-04) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20170811100330
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170809]

Comment 7

[Rodrigo]

With johannh's fix, the first tab doesn't have the start border even if there's an something before it in the tabbar. See this: https://i.imgur.com/srzl0F5.png

Comment 8

[:Gijs (he/him)]

(In reply to Rodrigo from comment #7)
> With johannh's fix, the first tab doesn't have the start border even if
> there's an something before it in the tabbar. See this:
> https://i.imgur.com/srzl0F5.png

Covered by bug 1390025, I think.

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-11), so I'm marking this bug as VERIFIED. Thanks.