1387550 - Support tiled drawing of blob images in Gecko

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

We'll need this for having sane invalidation.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add Tiling support to Moz2DImageRenderer

This add support for tiling to Moz2DImageRenderer by storing the tiling information and then using DrawTargetTiled to do the drawing.

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8897096 [details] [diff] [review]
Add Tiling support to Moz2DImageRenderer

Review of attachment 8897096 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/src/bindings.rs
@@ +667,5 @@
>      let mut resources = ResourceUpdates::new();
>      resources.add_image(image_key,
>                          descriptor.into(),
>                          ImageData::new_blob_image(copied_bytes),
> +                        Some(128));

Is this for testing only or do you plan to tile all blob images (128 seems quite small)?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Nicolas Silva [:nical] from comment #2)
> Comment on attachment 8897096 [details] [diff] [review]
> Add Tiling support to Moz2DImageRenderer
> 
> Review of attachment 8897096 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/webrender_bindings/src/bindings.rs
> @@ +667,5 @@
> >      let mut resources = ResourceUpdates::new();
> >      resources.add_image(image_key,
> >                          descriptor.into(),
> >                          ImageData::new_blob_image(copied_bytes),
> > +                        Some(128));
> 
> Is this for testing only or do you plan to tile all blob images (128 seems
> quite small)?

Mostly it's an arbitrary choice for testing. That being said, since we're using a texture atlas in the end it's conceivable that small tile sizes might work well.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Sounds like a pref to me :)

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8897096 [details] [diff] [review]
Add Tiling support to Moz2DImageRenderer

Review of attachment 8897096 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we can adjust the tile size later. It'd be great if you added a pref for this as Milan suggested.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9b7e7116b7
Support tiled drawing of blob images in Gecko.

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e9b7e7116b7