Closed Bug 1387682 Opened 4 years ago Closed 4 years ago

Screenshots missing when thumbnailer Promise is garbage collected

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

Assignee: nobody → edilee
Ah these are probably the leaks florian was trying to avoid:

22:33:05    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_drag_drop_ext.js | leaked 12 window(s) until shutdown [url = about:newtab]
22:33:05    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_undo.js | leaked 2 window(s) until shutdown [url = about:newtab]

These shouldn't be activity stream related but I guess the shutdown cleanup of observers isn't enough.
Comment on attachment 8894041 [details]
Bug 1387682 - Screenshots missing when thumbnailer Promise is garbage collected.

https://reviewboard.mozilla.org/r/165136/#review171218

Looks good to me, just one change to the comment. Thanks!

::: toolkit/components/thumbnails/BackgroundPageThumbs.jsm:93
(Diff revision 4)
>     * Asynchronously captures a thumbnail of the given URL if one does not
>     * already exist.  Otherwise does nothing.
>     *
>     * @param url      The URL to capture.
>     * @param options  An optional object that configures the capture.  See
>     *                 capture() for description.

Can you add 'unloadingPromise' to the options param comment in capture() like this comment suggests?
Attachment #8894041 - Flags: review?(usarracini) → review+
Comment on attachment 8894041 [details]
Bug 1387682 - Screenshots missing when thumbnailer Promise is garbage collected.

https://reviewboard.mozilla.org/r/165136/#review171218

> Can you add 'unloadingPromise' to the options param comment in capture() like this comment suggests?

Added comment to `captureIfMissing` as that's where it's used.
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/02f357c8e980
Screenshots missing when thumbnailer Promise is garbage collected. r=ursula
https://hg.mozilla.org/mozilla-central/rev/02f357c8e980
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Blocks: 1394533
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.