Closed Bug 1387726 Opened 7 years ago Closed 7 years ago

Dark Theme: identity block hover color is wrong/unexpected

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- verified

People

(Reporter: jan, Assigned: dao)

References

Details

(Keywords: nightly-community, Whiteboard: [reserve-photon-visual][p3])

Attachments

(4 files)

Nightly 57 x64 20170805100334 @ Debian Testing

Dark Theme:

1. The (green) EV bar text color is too dark and hard to read. Ideally it would have the same color as the padlock in Dark Theme(s).

2. The identity block background gets even darker while hovering.
I can't find a spec in Invision about this,
but I would like to see the colors used on
http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html (select the Dark theme and hover/mousedown on the identity block)
because I would expect a brighter color when hovering something dark.

See attached image.
Whiteboard: [photon-visual][triage]
Dupe of bug 1385277 ?
No. 1 is a duplicate of bug 1385277.
No. 2 not.
Summary: Dark Theme: green EV bar text is too dark and identity block hover color is wrong/unexpected → Dark Theme: identity block hover color is wrong/unexpected
Tomatoes on my eyes.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [photon-visual][triage]
In bug 1385277 was only fixed what was mentioned in the summary, but not both bugs from bug 1385277 comment 0.

This bug is about:
> 2. The identity block background gets even darker while hovering.
> I can't find a spec in Invision about this,
> but I would like to see the colors used on
> http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html (select the Dark theme and hover/mousedown on the identity block)
> because I would expect a brighter color when hovering something dark.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
See Also: → 1385277
Whiteboard: [photon-visual][triage]
Flags: qe-verify+
Priority: -- → P3
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p3]
QA Contact: brindusa.tot
Priority: P3 → P4
Blocks: 1363502
I tested on Ubuntu 16.04 with FF Nightly 57.0a1(2017-09-12) with the dark theme and when I hover the mouse over the identity block the color looks fine in my case. Jan can you please retest this with the latest Nightly? Thanks
Flags: needinfo?(jan)
Nightly 57 x64 de_DE 20170912220343 @ Debian Testing
Hovering the identity block in Dark Theme makes its background darker, while hovering an icon on the right side of the address bar shows a too bright background.
It's far from being consistent. In Default Theme, both background colors seem to be consistent and are looking good!
Flags: needinfo?(jan)
Assignee: nobody → dao+bmo
Status: REOPENED → ASSIGNED
Priority: P4 → P1
Iteration: --- → 57.3 - Sep 19
Comment on attachment 8907532 [details]
Bug 1387726 - Fix identity box hover and active color for dark themes.

https://reviewboard.mozilla.org/r/179240/#review184448

Looks much better, cheers
Attachment #8907532 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1b5f6150e68
Fix identity box hover and active color for dark themes. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/c1b5f6150e68
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Teste on Ubuntu 16.04 with FF Nightly 57.0a1(2017-09-18) and when I hover the mouse over the identity block(dark theme enabled) I have different a color code(#5d5d5e) than the one that is in the expected mockups(#4f4f50) http://design.firefox.com/people/shorlander/photon/Mockups/linux.html

Jan do you have the same results?
Flags: needinfo?(jan)
Nightly 57 x64 20170918220054 de_DE @ Debian Testing (KDE)

Dark Theme: Hover colors in Nightly are much brighter than on the mockup.
Flags: needinfo?(jan)
Based on comment 11 and comment 12 I will reopen this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
That's a minor but deliberate deviation form the spec. We're sticking with the current color as it works on both dark and light backgrounds.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Based on comment 14, I will mark this as verified fixed, this is the desired output.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.