Regression: Changing theme breaks default theme

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
VERIFIED FIXED
10 months ago
10 months ago

People

(Reporter: Sören Hentzschel, Assigned: ntim)

Tracking

({regression})

Trunk
Firefox 57
regression
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

10 months ago
Created attachment 8894103 [details]
bug

STR:

1. enable another theme in add-on mananger
2. switch back to default theme

expected:

The default theme is applied again.

actual result:

the default theme does not look like the default theme.

Please see the attached screencast.

Updated

10 months ago
Duplicate of this bug: 1387880

Updated

10 months ago
Duplicate of this bug: 1387752

Updated

10 months ago
Duplicate of this bug: 1387751
Can someone try finding the regression window with mozregression, please?
status-firefox56: --- → ?
Flags: qe-verify+
Keywords: regression, regressionwindow-wanted

Comment 5

10 months ago
(In reply to Johann Hofmann [:johannh] from comment #4)
> Can someone try finding the regression window with mozregression, please?

Will look into it...
Have to say that the theme which is born from "Default > Dark > Default" doesn't look bad.

Comment 7

10 months ago
mozregression points to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4cfb674227051e22bab651e5759f3de503a50560&tochange=a9182f92641b24d0a972886aed27e784004a343f which makes me suspect bug 1342712. Tim?
Blocks: 1342712
Flags: needinfo?(ntim.bugs)

Comment 8

10 months ago
Confirmed that this broke in bug 1342712.
Keywords: regressionwindow-wanted

Updated

10 months ago
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox56: ? → unaffected
(Assignee)

Updated

10 months ago
Assignee: nobody → ntim.bugs
Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 9

10 months ago
The issue is pretty straightforward:

When switching back to the default theme, aData and parsedData are null. So the check for parsedData.window throws.
Comment hidden (mozreview-request)

Comment 11

10 months ago
mozreview-review
Comment on attachment 8894466 [details]
Bug 1387737 - Fix switching back to the default theme.

https://reviewboard.mozilla.org/r/165642/#review170722
Attachment #8894466 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Updated

10 months ago
Duplicate of this bug: 1388010

Comment 13

10 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/864b3a48a8f8
Fix switching back to the default theme. r=Gijs

Comment 14

10 months ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/fde1450a4368
Fix switching back to the default theme. r=Gijs a=merge

Comment 15

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fde1450a4368
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
status-firefox55: --- → unaffected
status-firefox-esr52: --- → unaffected

Updated

10 months ago
Duplicate of this bug: 1388175

Updated

10 months ago
Duplicate of this bug: 1388272

Updated

10 months ago
Duplicate of this bug: 1388186

Updated

10 months ago
Duplicate of this bug: 1388322

Comment 21

10 months ago
Fixed on latest Nightly.
Status: RESOLVED → VERIFIED

Comment 22

10 months ago
Managed to reproduce the issue on an affected build (Firefox 57.0a1), using the steps to reproduce from Comment 0, on Windows 10 X 64 bit. Hence the bug-1387737 is fixed & verified.
build ID: 20170809100326
[bugday-20170809]
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.