1387830 - Allow ./mach lint to print its available linters

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Justin Wood (:Callek)]

When thinking about using ./mach lint -l ... I've wondered what linters are available a few times. This should help.

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1387830 - Make ./mach lint able to output available linters.

Review commit: https://reviewboard.mozilla.org/r/165300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165300/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8894218 [details]
Bug 1387830 - Make ./mach lint able to output available linters.

https://reviewboard.mozilla.org/r/165300/#review171176

Thanks!

::: python/mozlint/mozlint/cli.py:30
(Diff revision 1)
>            'default': [],
>            'action': 'append',
>            'help': "Linters to run, e.g 'eslint'. By default all linters "
>                    "are run for all the appropriate files.",
>            }],
> +        [['--list-linters'],

I think we could just call this `--list`. There's not much else it could be listing, so should be obvious what it's for.

::: python/mozlint/mozlint/cli.py:124
(Diff revision 1)
> +    if list_linters:
> +        lint_paths = find_linters(linters)
> +        print("Available linters: {}".format(
> +            [os.path.splitext(os.path.basename(l))[0] for l in lint_paths]
> +        ))
> +        sys.exit(0)

nit: just use return 0 in case the thing calling this wants to keep going.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8894218 [details]
Bug 1387830 - Make ./mach lint able to output available linters.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165300/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/393b0727cba4
Make ./mach lint able to output available linters. r=ahal

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for flake8 failures like https://treeherder.mozilla.org/logviewer.html#?job_id=121696671&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/96f8096db6320a178dd3d6f44ae31385c92b8f28

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8894218 [details]
Bug 1387830 - Make ./mach lint able to output available linters.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165300/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/640c562833fc
Make ./mach lint able to output available linters. r=ahal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/640c562833fc