Closed Bug 1387843 Opened 3 years ago Closed 1 year ago

Mirror the sidebar icon in the Library (Bookmarks & History) accordingly

Categories

(Firefox :: Toolbars and Customization, defect, P5)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox66 --- wontfix
firefox67 --- verified

People

(Reporter: itiel_yn8, Assigned: jawad, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 file)

The sidebar icon is displayed correctly on the toolbar if the user changes its side (from right to left and vice versa), but the same icon on the Library (Bookmarks & History) is static.
It should probably get mirrored accordingly once the user changes the sidebar location to the right/left.
Blocks: 1353421
Priority: -- → P5
Whiteboard: [reserve-photon-structure]
Flags: qe-verify-
Stealing this for a bit.
Assignee: nobody → gijskruitbosch+bugs
Assignee: gijskruitbosch+bugs → nobody
Mentor: gijskruitbosch+bugs

Hi, I am willing to work on it, Please assign it to me.

Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → ijawadak
Flags: needinfo?(gijskruitbosch+bugs)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Flags: needinfo?(ijawadak)

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Flags: needinfo?(ijawadak)

(In reply to Jawad Ahmed [:jawad] from comment #5)

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Glob, can you help on how to fix this state?

Flags: needinfo?(glob)
Attachment #9049409 - Attachment description: Bug 1387843 - Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=gijs → Bug 1387843 - Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=gijs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7592f919079f
Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=Gijs

This got sorted, thanks!

Flags: needinfo?(glob)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Looking good on latest Nightly. Thanks!

Status: RESOLVED → VERIFIED
See Also: → 1538013
You need to log in before you can comment on or make changes to this bug.