Mirror the sidebar icon in the Library (Bookmarks & History) accordingly

VERIFIED FIXED in Firefox 67

Status

()

defect
P5
normal
VERIFIED FIXED
2 years ago
13 days ago

People

(Reporter: itiel_yn8, Assigned: jawad, Mentored)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox66 wontfix, firefox67 verified)

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The sidebar icon is displayed correctly on the toolbar if the user changes its side (from right to left and vice versa), but the same icon on the Library (Bookmarks & History) is static.
It should probably get mirrored accordingly once the user changes the sidebar location to the right/left.

Updated

2 years ago
Blocks: 1353421
Priority: -- → P5
Whiteboard: [reserve-photon-structure]
Flags: qe-verify-
(Reporter)

Updated

2 years ago

Comment 1

a year ago
Stealing this for a bit.
Assignee: nobody → gijskruitbosch+bugs

Updated

9 months ago
Assignee: gijskruitbosch+bugs → nobody
Mentor: gijskruitbosch+bugs
(Assignee)

Comment 2

2 months ago

Hi, I am willing to work on it, Please assign it to me.

Flags: needinfo?(gijskruitbosch+bugs)

Updated

2 months ago
Assignee: nobody → ijawadak
Flags: needinfo?(gijskruitbosch+bugs)

Comment 4

a month ago

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Flags: needinfo?(ijawadak)
(Assignee)

Comment 5

a month ago

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Flags: needinfo?(ijawadak)

Comment 6

a month ago

(In reply to Jawad Ahmed [:jawad] from comment #5)

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Glob, can you help on how to fix this state?

Flags: needinfo?(glob)
Attachment #9049409 - Attachment description: Bug 1387843 - Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=gijs → Bug 1387843 - Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=gijs

Comment 7

a month ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7592f919079f
Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=Gijs

Comment 8

a month ago

This got sorted, thanks!

Flags: needinfo?(glob)

Comment 9

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
(Reporter)

Comment 10

a month ago

Looking good on latest Nightly. Thanks!

Status: RESOLVED → VERIFIED
(Reporter)

Updated

a month ago
See Also: → 1538013
You need to log in before you can comment on or make changes to this bug.