1387843 - Mirror the sidebar icon in the Library (Bookmarks & History) accordingly

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Itiel]

The sidebar icon is displayed correctly on the toolbar if the user changes its side (from right to left and vice versa), but the same icon on the Library (Bookmarks & History) is static.
It should probably get mirrored accordingly once the user changes the sidebar location to the right/left.

Comment 1

[:Gijs (he/him)]

Stealing this for a bit.

Comment 2

[Jawad Ahmed [:jawad]]

Hi, I am willing to work on it, Please assign it to me.

Comment 3

[Jawad Ahmed [:jawad]]

Attachment: Bug 1387843 - Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=gijs

Comment 4

[:Gijs (he/him)]

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Comment 5

[Jawad Ahmed [:jawad]]

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Comment 6

[:Gijs (he/him)]

(In reply to Jawad Ahmed [:jawad] from comment #5)

mirrored (In reply to :Gijs (he/him) from comment #4)

Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.

Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.

I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.

Glob, can you help on how to fix this state?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7592f919079f
Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=Gijs

Comment 8

[:Gijs (he/him)]

This got sorted, thanks!

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7592f919079f

Comment 10

[Itiel]

Looking good on latest Nightly. Thanks!