Mirror the sidebar icon in the Library (Bookmarks & History) accordingly
Categories
(Firefox :: Toolbars and Customization, defect, P5)
Tracking
()
People
(Reporter: itiel_yn8, Assigned: jawad, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-structure])
Attachments
(1 file)
The sidebar icon is displayed correctly on the toolbar if the user changes its side (from right to left and vice versa), but the same icon on the Library (Bookmarks & History) is static. It should probably get mirrored accordingly once the user changes the sidebar location to the right/left.
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Hi, I am willing to work on it, Please assign it to me.
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.
Assignee | ||
Comment 5•5 years ago
|
||
mirrored (In reply to :Gijs (he/him) from comment #4)
Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.
Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.
I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.
Comment 6•5 years ago
|
||
(In reply to Jawad Ahmed [:jawad] from comment #5)
mirrored (In reply to :Gijs (he/him) from comment #4)
Can you ensure moz-phab is set up correctly and use that to push to phabricator, and paste any error output you get here? It seems your commit wasn't correctly associated to neither a repository nor your full name etc.
Actually, the changeset i was working on with moz-phab accidentally removed with "strip" command, so i made another changeset, but submitting the new changeset with moz-phab would have created a new differential & i wanted to update the existing.
I ran "arc diff tip --update D22637" but it throws this error "Usage Exception: No changes found. (Did you specify the wrong commit range?)". I just exported the changeset and uploaded on the website.
Glob, can you help on how to fix this state?
Updated•5 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7592f919079f Fix & Mirrored Library (Bookmarks & History) icons, on sidebar position changed. r=Gijs
Comment 9•5 years ago
|
||
bugherder |
Reporter | ||
Comment 10•5 years ago
|
||
Looking good on latest Nightly. Thanks!
Updated•5 years ago
|
Description
•