1387846 - Print item in hamburger panel should print instead of opening print preview (like file menu)

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Open Hamburguer menu. The "Print..." entry has the Ctrl+P keyboard shortcut next to it.

There is just one problem: clicking "Print..." opens Print Preview instead of showing the Print dialog. But Ctrl+P shows the Print dialog. So they do different things. This is confusing.

Comment 1

[:Gijs (he/him)]

This is ultimately a UX issue. Changing the label is not difficult. We could also hide the shortcut on Windows/Linux, like we did prior to the photon work. Aaron, thoughts?

Comment 2

[Oriol Brufau [:Oriol]]

And "Print..." should be renamed to "Print Preview" if you want to be consistent with File menu.

Comment 3

[:Gijs (he/him)]

(In reply to Oriol [:Oriol] from comment #2)
> And "Print..." should be renamed to "Print Preview" if you want to be
> consistent with File menu.

The button in the hamburger panel always opened print preview and always just said "Print". It's not clear to me why this is suddenly an issue.

Comment 4

[bbell]

Attachment: Example

The Print Menu item should not open the print preview panel on any platform. That it is different on Mac vs. Windows is a bug and should be fixed.

Comment 5

[Maya Messinger]

Hi, Gijs pointed me to this bug, and I'd like to look at it, I can tackle it over the weekend. I'm pretty new to Bugzilla, so if you want to wait to assign this, no worries, but I'll take a stab at it. Thanks!

Comment 6

[Maya Messinger]

Attachment: Bug 1387846 change print button command to print instead of print preview on all platforms

Review commit: https://reviewboard.mozilla.org/r/180728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180728/

Comment 7

[Maya Messinger]

Hey Gijs, it was a really simple fix, and easy to find the file. Hope the push went well, it's ready for your review, I had a thing with differences about heads when I first pulled from the main repository, but doesn't look like that affected the patch. Thanks for pointing me to this one, it went much more smoothly!

Comment 8

[:Gijs (he/him)]

Comment on attachment 8909154 [details]
Bug 1387846 change print button command to print instead of print preview on all platforms

https://reviewboard.mozilla.org/r/180728/#review185778

Looks great, thanks! I'll try to find you something else in the morning, it's a bit late here (UK). :-)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aaa09eb300c
change print button command to print instead of print preview on all platforms r=Gijs

Comment 10

[:Gijs (he/him)]

Hey Maya, how comfortable are you with JS? Maybe bug 1396953 would be something you can tackle next? I tried to explain roughly what a fix could look like in bug 1396953 comment 1.

Comment 11

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1aaa09eb300c

Comment 12

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Thanks for your work, Maya!

Comment 13

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-06)  on windows 10 (32-bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-09-19) (32-bit)

Build ID: 20170919100405
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 14

[timbugzilla]

Are you going to introduce a print preview button to the menu?

This change has a negative effect on UX for me.

Comment 15

[:Gijs (he/him)]

(In reply to timbugzilla from comment #14)
> Are you going to introduce a print preview button to the menu?
> 
> This change has a negative effect on UX for me.

I'm not aware of plans to this effect. You could use the customizable print button to open print preview if you use it frequently.

Bryan, can you take a look? On non-mac, the print dialog offers no preview at all, so I'm not convinced this change is an improvement for Windows/Linux users.

Comment 16

[Dão Gottwald [::dao]]

(In reply to :Gijs from comment #15)
> (In reply to timbugzilla from comment #14)
> > Are you going to introduce a print preview button to the menu?
> > 
> > This change has a negative effect on UX for me.
> 
> I'm not aware of plans to this effect. You could use the customizable print
> button to open print preview if you use it frequently.
> 
> Bryan, can you take a look? On non-mac, the print dialog offers no preview
> at all, so I'm not convinced this change is an improvement for Windows/Linux
> users.

FWIW, we should revert this. This item opened the print preview precisely because we didn't want an extra item for that in the panel. This was a deliberate UX decision and not a bug, as opposed to what comment 4 says.

Comment 17

[bbell]

(In reply to Dão Gottwald [::dao] from comment #16)

> FWIW, we should revert this. This item opened the print preview precisely
> because we didn't want an extra item for that in the panel. This was a
> deliberate UX decision and not a bug, as opposed to what comment 4 says.

I agree with Dão. The original mistake was to label it with the wrong key-command-tip. If we're going to have only one print entry point in the Menu, then it should start with the print preview.

Comment 18

[:Gijs (he/him)]

(In reply to bbell from comment #17)
> (In reply to Dão Gottwald [::dao] from comment #16)
> 
> > FWIW, we should revert this. This item opened the print preview precisely
> > because we didn't want an extra item for that in the panel. This was a
> > deliberate UX decision and not a bug, as opposed to what comment 4 says.
> 
> I agree with Dão. The original mistake was to label it with the wrong
> key-command-tip. If we're going to have only one print entry point in the
> Menu, then it should start with the print preview.

I filed bug 1401754 to address this.

Comment 19

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

Reproduced this bug on an affected Nightly build from 2017-08-06.

This is also verified fixed on Beta 57.0b7 (20171009192146) under Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.