Closed
Bug 1387889
Opened 7 years ago
Closed 7 years ago
German 'ß' (sz) triggers save button in simple machines forum
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect, P2)
Tracking
(fennec+, firefox55 unaffected, firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: klorgfasder, Assigned: jchen)
References
Details
Attachments
(1 file)
2.47 KB,
patch
|
esawin
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10) AppleWebKit/537.36 (KHTML, like Gecko) Version/8.0 Safari/537.36 Steps to reproduce: Open a post edit field (new thread / answer) on a forum powered by simple machines (http://simplemachines.org/) and type an 'ß' (german sz). Please note: Only Firefox Mobile shows this behaviour - no other browser, may it be chrome, opera, or any other. Actual results: As if the 'save' button had been pressed, the form is submitted. Expected results: A 'ß' should appear in the textarea element.
Comment 1•7 years ago
|
||
I can reproduce this issue, by trying to post a comment on a thread from http://simplemachines.org/ (you need to create an account for this). With the keyboard set to German, tap the single letter 'ß' (from the autocomplete suggestions in my case). Result: The edit form is dismissed and would be posted if the captcha is correct. Device: LG Nexus 5 (Android 6.0.1) Keyboards used: Gboard & SwiftKey Build: Nightly 57 (2017-22-08) Could not reproduce on Fennec Beta 56 or Fennec 55.
Status: UNCONFIRMED → NEW
tracking-fennec: --- → ?
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox57:
--- → affected
Ever confirmed: true
Comment 2•7 years ago
|
||
Hi Joe, Wesly Please help me prioritize this. Thanks!
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Assignee: nobody → nchen
tracking-fennec: ? → +
Priority: -- → P2
Assignee | ||
Comment 3•7 years ago
|
||
Some key events synthesized from strings can have modifier metastates. For example, from the sharp S character, we synthesize an S key with Alt metastate. However, we don't actually want to pass the Alt metastate to Gecko because the Alt meta key is not actually pressed in this case.
Attachment #8901005 -
Flags: review?(esawin)
Comment 4•7 years ago
|
||
let's go with Snorp's priority and it looks like Jim's on it
Flags: needinfo?(jcheng)
Updated•7 years ago
|
Flags: needinfo?(wehuang)
Updated•7 years ago
|
Attachment #8901005 -
Flags: review?(esawin) → review+
Assignee | ||
Updated•7 years ago
|
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20e283d11850 Don't pass along metastate of synthesized keys; r=esawin
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/20e283d11850
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8901005 [details] [diff] [review] Don't pass along metastate of synthesized keys (v1) Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: Possible unexpected behavior when entering text, e.g. entering non-English characters could trigger unexpected site actions. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Small patch that only addresses this specific issue. [String changes made/needed]: None
Attachment #8901005 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
If we couldn't reproduce it on beta 56, are you sure we should uplift this?
Flags: needinfo?(nchen)
Assignee | ||
Comment 9•7 years ago
|
||
Sorry, I should have mentioned I was able to reproduce it on 56 Beta on my device.
Flags: needinfo?(nchen)
Comment 10•7 years ago
|
||
Comment on attachment 8901005 [details] [diff] [review] Don't pass along metastate of synthesized keys (v1) Fix a keyboard issue. Beta56+.
Attachment #8901005 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/2b4f305aed0a
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•