1387902 - Don't attempt to localize browserAction widget properties

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Kris Maglione [:kmag]]

We spend a lot of time at startup generating exception objects while trying to retrieve nonexistent localized properties from string bundles. Since extension widget values will never be localized this way, we should skip the string bundle lookup entirely.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1387902: Don't attempt to localize browserAction widget properties.

We spend a lot of time at startup generating exception objects while trying to
retrieve nonexistent localized properties from string bundles. Since extension
widget values will never be localized this way, we should skip the string
bundle lookup entirely.

Review commit: https://reviewboard.mozilla.org/r/165532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165532/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8894364 [details]
Bug 1387902: Don't attempt to localize browserAction widget properties.

https://reviewboard.mozilla.org/r/165532/#review170724

r=me

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83e23294455f89c13e3a2db5b04291641a19c52f
Bug 1387902: Don't attempt to localize browserAction widget properties. r=Gijs

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83e23294455f