Make --max-frames=8 the default for dmd.py

RESOLVED FIXED in Firefox 57

Status

()

Core
DMD
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
The current default is 24, which is equal to the maximum number of stack frames
that DMD will record. And that's a terrible value because it splits up too many
related stack traces into separate records. There is no single best value, but
8 is a much better default.
(Assignee)

Comment 1

11 months ago
Created attachment 8894395 [details] [diff] [review]
Make --max-frames=8 the default for dmd.py

mccr8, I've changed block_analyzer.py in the same way. Is that reasonable?
Attachment #8894395 - Flags: review?(continuation)
Comment on attachment 8894395 [details] [diff] [review]
Make --max-frames=8 the default for dmd.py

Review of attachment 8894395 [details] [diff] [review]:
-----------------------------------------------------------------

I don't remember what role that plays in block_analyzer, but I'm sure it is fine.
Attachment #8894395 - Flags: review?(continuation) → review+

Comment 4

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37f23109abe3
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.