stylo: Interpolation of "vertical-align" is not correct in test_transitions_per_property.html

RESOLVED FIXED in Firefox 57

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: boris, Assigned: hiro)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Got a failure while testing vertical-align:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | percent-valued property vertical-align: interpolation of percents: 25% should be a quarter of the way between 75% and 25% - got 100, expected 25
(Assignee)

Comment 1

3 months ago
We missed Percentage case somehow.
https://hg.mozilla.org/mozilla-central/file/824d4f269c63/servo/components/style/properties/helpers/animated_properties.mako.rs#l964
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4994521304c17319043fa5d4312f994c53996982
Comment hidden (mozreview-request)

Comment 4

3 months ago
mozreview-review
Comment on attachment 8897210 [details]
Bug 1387949 - Make vertical-align animatable between percentage and percentage or length.

https://reviewboard.mozilla.org/r/168488/#review173736

Thanks!

::: commit-message-99a4e:1
(Diff revision 1)
> +Bug 1387949 - Make vertical-align animtable between percentage and percentage or length. r?birtles

s/animtable/animatable/
Attachment #8897210 - Flags: review?(bbirtles) → review+
(Assignee)

Comment 5

3 months ago
Created attachment 8897218 [details] [review]
Servo PR
Comment hidden (mozreview-request)

Comment 7

3 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97f505131cd6
Make vertical-align animatable between percentage and percentage or length. r=birtles

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/97f505131cd6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.