Closed Bug 1387949 Opened 5 years ago Closed 5 years ago

stylo: Interpolation of "vertical-align" is not correct in test_transitions_per_property.html

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: boris, Assigned: hiro)

References

Details

Attachments

(2 files)

Got a failure while testing vertical-align:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | percent-valued property vertical-align: interpolation of percents: 25% should be a quarter of the way between 75% and 25% - got 100, expected 25
We missed Percentage case somehow.
https://hg.mozilla.org/mozilla-central/file/824d4f269c63/servo/components/style/properties/helpers/animated_properties.mako.rs#l964
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Comment on attachment 8897210 [details]
Bug 1387949 - Make vertical-align animatable between percentage and percentage or length.

https://reviewboard.mozilla.org/r/168488/#review173736

Thanks!

::: commit-message-99a4e:1
(Diff revision 1)
> +Bug 1387949 - Make vertical-align animtable between percentage and percentage or length. r?birtles

s/animtable/animatable/
Attachment #8897210 - Flags: review?(bbirtles) → review+
Attached file Servo PR
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97f505131cd6
Make vertical-align animatable between percentage and percentage or length. r=birtles
https://hg.mozilla.org/mozilla-central/rev/97f505131cd6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.