Closed
Bug 1387949
Opened 8 years ago
Closed 8 years ago
stylo: Interpolation of "vertical-align" is not correct in test_transitions_per_property.html
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: boris, Assigned: hiro)
References
Details
Attachments
(2 files)
Got a failure while testing vertical-align:
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | percent-valued property vertical-align: interpolation of percents: 25% should be a quarter of the way between 75% and 25% - got 100, expected 25
|
Assignee | |
Comment 1•8 years ago
|
||
We missed Percentage case somehow.
https://hg.mozilla.org/mozilla-central/file/824d4f269c63/servo/components/style/properties/helpers/animated_properties.mako.rs#l964
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897210 [details]
Bug 1387949 - Make vertical-align animatable between percentage and percentage or length.
https://reviewboard.mozilla.org/r/168488/#review173736
Thanks!
::: commit-message-99a4e:1
(Diff revision 1)
> +Bug 1387949 - Make vertical-align animtable between percentage and percentage or length. r?birtles
s/animtable/animatable/
Attachment #8897210 -
Flags: review?(bbirtles) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
| Comment hidden (mozreview-request) |
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97f505131cd6
Make vertical-align animatable between percentage and percentage or length. r=birtles
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•