Closed Bug 1387987 Opened 7 years ago Closed 7 years ago

List header in the new notification permission dialog scrolls with list items

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

Attachments

(2 files)

If you have more than a couple of items in the list in the notification permission dialog, scrolling them will make the header scroll as well, it should probably stick to the top instead.
Flags: qe-verify+
Comment on attachment 8894442 [details]
Bug 1387987 - Use listheader instead of richlistitem as list header in the permission dialog.

https://reviewboard.mozilla.org/r/165624/#review170794
Attachment #8894442 - Flags: review?(prathikshaprasadsuman) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66576627d41e
Use listheader instead of richlistitem as list header in the permission dialog. r=prathiksha
https://hg.mozilla.org/mozilla-central/rev/66576627d41e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Attached video permission dialog.mp4
I couldn't reproduce this issue on Nightly 57.0a1 (2017-08-07)(64-bit) on Windows 10.
Maybe I'm doing something wrong but somehow I can't see the scroll in permission dialog even with have many items in the list.

Johann could you please help us with more details maybe i'm skipping some steps here?

Thanks.
Flags: needinfo?(jhofmann)
(In reply to Hani Yacoub from comment #5)
> Created attachment 8909696 [details]
> permission dialog.mp4
> 
> I couldn't reproduce this issue on Nightly 57.0a1 (2017-08-07)(64-bit) on
> Windows 10.
> Maybe I'm doing something wrong but somehow I can't see the scroll in
> permission dialog even with have many items in the list.
> 
> Johann could you please help us with more details maybe i'm skipping some
> steps here?
> 
> Thanks.

You're looking at the wrong dialog ;)

What this bug is referring to is the notification permission settings in about:preferences.

about:preferences -> Privacy & Security -> Permissions
Flags: needinfo?(jhofmann)
Build ID: 20170918220054
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: