Closed Bug 1388048 Opened 5 years ago Closed 5 years ago

Check for failure of ResolveJunctionPointsAndSymLinks in GeckoChildProcessHost::GetPathToBinary

Categories

(Core :: Security: Process Sandboxing, enhancement, P1)

All
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

(Whiteboard: sbwc2)

Attachments

(1 file)

I should have checked ResolveJunctionPointsAndSymLinks for failure in GeckoChildProcessHost::GetPathToBinary.

It is possible that this is causing issues with mozregression.
This patch also adds logging into ResolveJunctionPointsAndSymLinks to help diagnose issues that
might arise if the resolution fails or the path is not usable for some reason.

(Can't push to try at the moment, it's got issues. Will do as soon as they're sorted.)
Attachment #8894546 - Flags: review?(jmathies)
Attachment #8894546 - Flags: review?(jmathies) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b8502cbb27c0
Check for failure of ResolveJunctionPointsAndSymLinks in GeckoChildProcessHost::GetPathToBinary. r=jimm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b8502cbb27c0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.