1388072 - Remove fallback Marionette preferences from geckodriver

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

geckodriver sets some deprecated preferences in the profile to configure Marionette:

> // fallbacks can be removed when Firefox 54 becomes stable
> if let Some(ref level) = self.current_log_level {
>     prefs.insert("marionette.log.level", Pref::new(level.to_string()));
>     prefs.insert("marionette.logging", Pref::new(level.to_string()));  // fallback
> };
> prefs.insert("marionette.port", Pref::new(port as i64));
> prefs.insert("marionette.defaultPrefs.port", Pref::new(port as i64));  // fallback

These were renamed in Firefox 54 and also uplifted to Firefox 53.  It should now be safe to remove these from geckodriver, as the next version (0.19.0) will require Firefox 55.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388072 - Drop Marionette fallback prefs from geckodriver.

The marionette.defaultPrefs.port and marionette.logging preferences were
removed in https://bugzil.la/1344748, which shipped in Firefox 54.
Because the next version of geckodriver (0.19.0) will only support
Firefox 55 and greater, it is safe to remove the fallbacks.

Review commit: https://reviewboard.mozilla.org/r/165696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165696/

Comment 2

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '30618' on host 'hgssh4.dmz.scl3.mozilla.com/effffffc'
remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by 'hgssh4.dmz.scl3.mozilla.com/effffffc:30618'
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 3

[David Burns :automatedtester]

Comment on attachment 8894525 [details]
Bug 1388072 - Drop Marionette fallback prefs from geckodriver.

https://reviewboard.mozilla.org/r/165696/#review171364

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f17b7789a510
Drop Marionette fallback prefs from geckodriver. r=automatedtester

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f17b7789a510

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreas, you missed to also remove the assertion in geckodriver tests:
https://dxr.mozilla.org/mozilla-central/source/testing/geckodriver/src/capabilities.rs#512-513

I will take care of it in my patch on bug 1387092.