Closed Bug 1388072 Opened 3 years ago Closed 3 years ago

Remove fallback Marionette preferences from geckodriver

Categories

(Testing :: geckodriver, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

geckodriver sets some deprecated preferences in the profile to configure Marionette:

> // fallbacks can be removed when Firefox 54 becomes stable
> if let Some(ref level) = self.current_log_level {
>     prefs.insert("marionette.log.level", Pref::new(level.to_string()));
>     prefs.insert("marionette.logging", Pref::new(level.to_string()));  // fallback
> };
> prefs.insert("marionette.port", Pref::new(port as i64));
> prefs.insert("marionette.defaultPrefs.port", Pref::new(port as i64));  // fallback

These were renamed in Firefox 54 and also uplifted to Firefox 53.  It should now be safe to remove these from geckodriver, as the next version (0.19.0) will require Firefox 55.
Assignee: nobody → ato
Status: NEW → ASSIGNED
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '30618' on host 'hgssh4.dmz.scl3.mozilla.com/effffffc'
remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by 'hgssh4.dmz.scl3.mozilla.com/effffffc:30618'
abort: stream ended unexpectedly (got 0 bytes, expected 4)
Comment on attachment 8894525 [details]
Bug 1388072 - Drop Marionette fallback prefs from geckodriver.

https://reviewboard.mozilla.org/r/165696/#review171364
Attachment #8894525 - Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f17b7789a510
Drop Marionette fallback prefs from geckodriver. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/f17b7789a510
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Andreas, you missed to also remove the assertion in geckodriver tests:
https://dxr.mozilla.org/mozilla-central/source/testing/geckodriver/src/capabilities.rs#512-513

I will take care of it in my patch on bug 1387092.
You need to log in before you can comment on or make changes to this bug.