1388087 - new nightly logo is oddly placed on "about nightly" window

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Screenshot 2017-08-07 12.04.24.png

See the attached screenshot.  Since the nightly logo was updated it seems oddly placed in the "about nightly" popup window.  It doesn't seem centered either vertically or horizontally in the empty space to the left of the text.

Comment 1

[:Gijs (he/him)]

Stephen, can you take a look?

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1388087 - Position the new Nightly logo in the about dialog.

Review commit: https://reviewboard.mozilla.org/r/165954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165954/

Comment 3

[Stephen Horlander [:shorlander]]

Comment on attachment 8894814 [details]
Bug 1388087 - Position the new Nightly logo in the about dialog.

https://reviewboard.mozilla.org/r/165954/#review171180

Looks good, thank you!

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 8894814 [details]
Bug 1388087 - Position the new Nightly logo in the about dialog.

https://reviewboard.mozilla.org/r/165954/#review171182

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2bee09f932b
Position the new Nightly logo in the about dialog. r=shorlander

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2bee09f932b

Comment 7

[Madhuri]

[bugday-20170809] 

status-ff57.0a1 : VERIFIED & NOT FIXED.

Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.

The issue is still reproducible on Firefox latest Nightly [BuildID : 20170808114032 , 57.0a1 (2017-08-08) (32-bit)]

Please refer screenshot.

Comment 8

[Madhuri]

Attachment: nightly_logo.png

Comment 9

[:Gijs (he/him)]

(In reply to Madhuri from comment #7)
> [bugday-20170809] 
> 
> status-ff57.0a1 : VERIFIED & NOT FIXED.
> 
> Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.
> 
> The issue is still reproducible on Firefox latest Nightly [BuildID :
> 20170808114032 , 57.0a1 (2017-08-08) (32-bit)]
> 
> Please refer screenshot.

This didn't land for yesterday's nightly, it only got fixed today. Please re-test with today's nightly.

Comment 10

[Madhuri]

(In reply to :Gijs from comment #9)
> (In reply to Madhuri from comment #7)
> > [bugday-20170809] 
> > 
> > status-ff57.0a1 : VERIFIED & NOT FIXED.
> > 
> > Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.
> > 
> > The issue is still reproducible on Firefox latest Nightly [BuildID :
> > 20170808114032 , 57.0a1 (2017-08-08) (32-bit)]
> > 
> > Please refer screenshot.
> 
> This didn't land for yesterday's nightly, it only got fixed today. Please
> re-test with today's nightly.

[BuildID :
> > 20170808114032 , 57.0a1 (2017-08-08) (32-bit)] this is the only build ID I have for today under bug verification day. I cannot see any new update notification or green arrow icon for further updated build. Hence I updated the status accordingly :-)

Comment 11

[Madhuri]

(In reply to :Gijs from comment #9)
> (In reply to Madhuri from comment #7)
> > [bugday-20170809] 
> > 
> > status-ff57.0a1 : VERIFIED & NOT FIXED.
> > 
> > Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.
> > 
> > The issue is still reproducible on Firefox latest Nightly [BuildID :
> > 20170808114032 , 57.0a1 (2017-08-08) (32-bit)]
> > 
> > Please refer screenshot.
> 
> This didn't land for yesterday's nightly, it only got fixed today. Please
> re-test with today's nightly.

I think the new updated build for today has not been deployed yet.

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

FWIW, you can look at about:buildconfig in a tab to see what revision your current build was created from.  Sometimes that helps, although determining if a change is in that rev can still be a bit confusing.

Comment 13

[Madhuri]

(In reply to Ben Kelly [:bkelly] from comment #12)
> FWIW, you can look at about:buildconfig in a tab to see what revision your
> current build was created from.  Sometimes that helps, although determining
> if a change is in that rev can still be a bit confusing.

Updated the build to 20170809100326 (this was not available at that time earlier) on Win 7 X 64.

The issue is still reproducible on Firefox latest Nightly [BuildID : 20170809100326 , 57.0a1 (2017-08-09) (64-bit)]. There is margin of pixels in top and bottom margins. Logo should be in center.

Please refer screenshot.

Comment 14

[Madhuri]

Attachment: latest_icon.png

Comment 15

[Dão Gottwald [:dao]]

The logo is intentionally closer to the top rather than vertically centered.

Comment 16

[Ben Kelly [:bkelly, not reviewing]]

I reported it, but am not the person working to fix it.  I think you meant to NI them?

Comment 17

[Saddam Hossain]

I have reproduced this Bug on Nightly 57.0a1 (2017-08-07) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 57.0a1

Build ID :   20170814100258
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 18

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly  57.0a1 (2017-08-07) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 57.0a1

Build ID 	20170814100258
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

[Bugday-20170809]

Comment 19

[Madhuri]

[bugday-20170823] 

status-ff57.0a1 : VERIFIED & NOT FIXED.

Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.

The issue is still reproducible on Firefox latest Nightly [BuildID : 20170823100553 , 57.0a1 (2017-08-23) (32-bit)]