Closed Bug 1388107 Opened 2 years ago Closed 2 years ago

Support unknown capability values in the sitePermissions.xul dialog.

Categories

(Firefox :: Preferences, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: prathiksha, Assigned: prathiksha)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

https://reviewboard.mozilla.org/r/185648/#review191452

Thanks!

::: browser/components/preferences/sitePermissions.js:74
(Diff revision 1)
>        return;
>  
>      let permission = subject.QueryInterface(Components.interfaces.nsIPermission);
>  
> -    // Ignore unrelated permission types.
> -    if (permission.type !== this._type)
> +    // Ignore unrelated permission types and permissions with unknown states.
> +    let states = [SitePermissions.ALLOW, SitePermissions.BLOCK, SitePermissions.PROMPT];

Nit: you could make this a constant
Attachment #8914372 - Flags: review?(jhofmann) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/85888997be88
Support unknown capability values in the sitePermissions.xul dialog. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/85888997be88
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1373206
[User impact if declined]: chances of site permissions dialog breaking
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: just an edge case fix
[String changes made/needed]: no
Attachment #8914372 - Flags: approval-mozilla-beta?
Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Photon polish, Beta57+
Attachment #8914372 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.