1388117 - ./mach test doesn't support the jsdebugger option

Status: RESOLVED DUPLICATE of bug 1289444

(Testing :: General, enhancement)

Description

[Brian Grinstead [:bgrins]]

For example, this works:

  ./mach mochitest browser/base/content/test/sidebar/browser_sidebar_move.js --jsdebugger

But this doesn't:

  ./mach test browser/base/content/test/sidebar/browser_sidebar_move.js --jsdebugger

It fails with:

  > It looks like you passed an unrecognized argument into mach.
  > The test command does not accept the arguments: --jsdebugger

The same thing happens with all arguments that are valid in for individual suite's command but isn't part of `test`.

Would it be possible to pass along arguments to the harnesses that get invoked from the test command? Then if that harness doesn't support the argument it would throw itself.

Comment 1

[Julian Descottes [:jdescottes]]

Looks like a similar bug was opened for --disable-e10s, seems non trivial: Bug 1289444

Comment 2

[Julian Descottes [:jdescottes]]

The main issue raised in Bug 1289444 seemed to be that some arguments could be accepted by some test harness and not by other, and what should be done if a single ./mach test command spawns tests from different test harness. 

But the proposition in the review to fail for test suites that don't support the argument seems reasonable to me. For --jsdebugger for instance you would most likely use it with a single test.

Comment 3

[Julian Descottes [:jdescottes]]

Just tested with the patch from Bug 1289444 which is about to land and it does fix the issue. Closing as dupe.