Closed
Bug 1388229
Opened 7 years ago
Closed 7 years ago
Update libcubeb to revision d5901039
Categories
(Core :: Audio/Video: cubeb, enhancement, P1)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(2 files, 1 obsolete file)
|
20.21 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
|
12.64 KB,
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
The only change this brings in is: 590103 Remove unused B2G-only stream_type field from cubeb_stream_params. (#347) ...which requires changes on the Gecko side.
|
Assignee | |
Comment 1•7 years ago
|
||
Carrying r+ forward from https://github.com/kinetiknz/cubeb/pull/347
Attachment #8894726 -
Flags: review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
This removes the minimal amount of AudioChannel/stream_type handling to build. There's a bunch of other code that can probably be removed, but that can be done in a follow-up bug.
Attachment #8894728 -
Flags: review?(dglastonbury)
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #2) > There's a bunch of other code that can probably be removed, but that > can be done in a follow-up bug. Bug 1388236.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8894728 [details] [diff] [review] Remove B2G-only audio stream type handling. Forgot to include the GraphDriver fixes in this patch.
Attachment #8894728 -
Attachment is obsolete: true
Attachment #8894728 -
Flags: review?(dglastonbury)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8894738 -
Flags: review?(dglastonbury)
|
|
Assignee | |
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dcee85e03029d5d1a83acbaaa8369873376ee0f
|
||
Updated•7 years ago
|
Rank: 16
Priority: -- → P1
Attachment #8894738 -
Flags: review?(dglastonbury) → review+
(In reply to Matthew Gregan [:kinetik] from comment #7) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=4dcee85e03029d5d1a83acbaaa8369873376ee0f Looks like Windows has had a conniption.
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/756ddbfd01fc Update libcubeb to revision d59010139. r=kamidphish https://hg.mozilla.org/integration/mozilla-inbound/rev/783e97842920 Remove B2G-only audio stream type handling. r=kamidphish
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/756ddbfd01fc https://hg.mozilla.org/mozilla-central/rev/783e97842920
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•