Update libcubeb to revision d5901039

RESOLVED FIXED in Firefox 57

Status

()

Core
Audio/Video: cubeb
P1
normal
Rank:
16
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 months ago
The only change this brings in is:

590103 Remove unused B2G-only stream_type field from cubeb_stream_params. (#347)

...which requires changes on the Gecko side.
(Assignee)

Comment 1

10 months ago
Created attachment 8894726 [details] [diff] [review]
Update libcubeb to revision d59010139.

Carrying r+ forward from https://github.com/kinetiknz/cubeb/pull/347
Attachment #8894726 - Flags: review+
(Assignee)

Comment 2

10 months ago
Created attachment 8894728 [details] [diff] [review]
Remove B2G-only audio stream type handling.

This removes the minimal amount of AudioChannel/stream_type handling to build.  There's a bunch of other code that can probably be removed, but that can be done in a follow-up bug.
Attachment #8894728 - Flags: review?(dglastonbury)
(Assignee)

Comment 4

10 months ago
(In reply to Matthew Gregan [:kinetik] from comment #2)
> There's a bunch of other code that can probably be removed, but that
> can be done in a follow-up bug.

Bug 1388236.
(Assignee)

Comment 5

10 months ago
Comment on attachment 8894728 [details] [diff] [review]
Remove B2G-only audio stream type handling.

Forgot to include the GraphDriver fixes in this patch.
Attachment #8894728 - Attachment is obsolete: true
Attachment #8894728 - Flags: review?(dglastonbury)
(Assignee)

Comment 6

10 months ago
Created attachment 8894738 [details] [diff] [review]
Remove B2G-only audio stream type handling.
Attachment #8894738 - Flags: review?(dglastonbury)
Rank: 16
Priority: -- → P1
(Assignee)

Updated

10 months ago
Blocks: 1388236
Attachment #8894738 - Flags: review?(dglastonbury) → review+
(In reply to Matthew Gregan [:kinetik] from comment #7)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=4dcee85e03029d5d1a83acbaaa8369873376ee0f

Looks like Windows has had a conniption.

Comment 9

10 months ago
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/756ddbfd01fc
Update libcubeb to revision d59010139.  r=kamidphish
https://hg.mozilla.org/integration/mozilla-inbound/rev/783e97842920
Remove B2G-only audio stream type handling.  r=kamidphish

Comment 10

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/756ddbfd01fc
https://hg.mozilla.org/mozilla-central/rev/783e97842920
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.