Closed Bug 1388236 Opened 2 years ago Closed 2 years ago

Remove B2G-only AudioChannel code

Categories

(Core :: Audio/Video, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(7 files, 1 obsolete file)

Bug 1388229 and https://github.com/kinetiknz/cubeb/pull/347 remove this from libcubeb and the immediate callers.  Some of the Gecko code was removed in bug 1358061 and bug 1299390 but there are still references throughout the media code that can be removed, e.g.: MediaElement downwards, WebAudio code, MSG code (including where MSG is created per-AudioChannel), HTMLMediaElement.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #8894744 - Attachment is obsolete: true
Attachment #8894744 - Flags: review?(jwwang)
Not sure who should review this one, :baku and :alwu are both away.
Attachment #8894741 - Flags: review?(jwwang) → review+
Attachment #8894756 - Flags: review?(jwwang) → review+
Attachment #8894757 - Flags: review?(jwwang) → review+
Attachment #8894743 - Flags: review?(padenot) → review+
Comment on attachment 8894742 [details] [diff] [review]
Remove B2G-only AudioChannel code from MSG.

Review of attachment 8894742 [details] [diff] [review]:
-----------------------------------------------------------------

Cool patches :-)
Attachment #8894742 - Flags: review?(padenot) → review+
Depends on: 1388229
Attachment #8894760 - Flags: review?(alwu)
Comment on attachment 8894760 [details] [diff] [review]
Remove B2G-only AudioChannel code from dom/audiochannel.

Review of attachment 8894760 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

::: dom/audiochannel/AudioChannelService.h
@@ +188,5 @@
>      void NotifyMediaBlockStop(nsPIDOMWindowOuter* aWindow);
>  
>      uint64_t mWindowID;
>      bool mIsAudioCaptured;
> +    AudioChannelConfig mChannelConfig;

Move |mNumberOfAgents| into |AudioPlaybackConfig|, and then we can remove |AudioPlaybackConfig|.

And rename it to mConfig.
Attachment #8894760 - Flags: review?(alwu) → review+
I split the dom/webidl deletions out from the last patch (attachment 8894760 [details] [diff] [review]) since they need DOM peer review.
Attachment #8895634 - Flags: review?(bugs)
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35fc4a82ffa7
Remove B2G-only AudioChannel code from media playback.  r=jwwang
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc09d80caba
Remove B2G-only AudioChannel code from MSG.  r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e8da5bc4301
Remove B2G-only AudioChannel code from WebAudio.  r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b330ab8f752
Remove B2G-only AudioChannel code from HTMLMediaElement.  r=jwwang
https://hg.mozilla.org/integration/mozilla-inbound/rev/aef8c26b4774
Remove B2G-only AudioChannel code from dom/ipc.  r=jwwang
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbedde5d27b4
Remove B2G-only AudioChannel code from dom/audiochannel.  r=alwu
https://hg.mozilla.org/integration/mozilla-inbound/rev/d79d7873a618
Remove now obsolete AudioChannelConfig in favour of AudioPlaybackConfig.  r=alwu
Marking leave-open for attachment 8895634 [details] [diff] [review].
Keywords: leave-open
(In reply to Alastor Wu [:alwu][please needinfo me][GMT+8] from comment #11)
> Move |mNumberOfAgents| into |AudioPlaybackConfig|, and then we can remove
> |AudioPlaybackConfig|.
> 
> And rename it to mConfig.

Good suggestion, thanks.  Done in d79d7873a618.
Attachment #8895634 - Flags: review?(bugs) → review+
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f77126a6e7fa
Remove B2G-only AudioChannel code from dom/webidl.  r=smaug
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.