1388254 - Fix borrowed DrawTarget's transform of DXGITextureData.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

This bug is created based on Bug 1380979 Comment 7.

DrawTarget of DXGITextureData was recycled between Lock()s. But transform of DrawTarget was not reset for each Lock().

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix borrowed DrawTarget's transform of DXGITextureData

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix borrowed DrawTarget's transform of DXGITextureData

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d375668168dab1f0461b424e7ad968eee35ff44

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8894790 [details] [diff] [review]
patch - Fix borrowed DrawTarget's transform of DXGITextureData

Review of attachment 8894790 [details] [diff] [review]:
-----------------------------------------------------------------

We might need to do something similar with clips and other drawing state? I expect drawing code that pushes clips to be responsible for popping them so it may not be necessary. Maybe it would help if we had a cheap way to clear all of the drawing state (except the rendered texture).

Comment 5

[Sotaro Ikeda [:sotaro]]

DrawTarget class has a following member. They might need to be cleared. But I want to leave it for now.

> protected:
>  UserData mUserData;
>  Matrix mTransform;
>  IntRect mOpaqueRect;
>  bool mTransformDirty : 1;
>  bool mPermitSubpixelAA : 1;
>
>  SurfaceFormat mFormat;

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2b2a11109ef
Fix borrowed DrawTarget's transform of DXGITextureData r=nical

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2b2a11109ef