1388264 - Port bug 1291331 to TB [Update last modified time on start menu shortcuts during install or update]

Status: RESOLVED FIXED

(Thunderbird :: Installer, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1291331 is on the way to land. We should follow to not be less in sync.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: installer.patch

This is a 1:1 copy of https://hg.mozilla.org/integration/mozilla-inbound/rev/e68e6723cff722c5e948ff8851bc589bda6a3be0

It's about to land today. We can wait until the next following Nightly and see if it works as desired with updating the Start icon. Until now I have still the old one and would see immediately if it works.

Comment 2

[Jorg K (CEST = GMT+2)]

Looks good.

(In reply to Richard Marti (:Paenglab) from comment #1)
> It's about to land today. We can wait until the next following Nightly and
> see if it works as desired with updating the Start icon.
No merges until now, so do you want this to land before noon tomorrow or after noon tomorrow? Sorry, I don't understand "wait until the next following Nightly".

How about fixing IB and SM as well?

Comment 3

[Richard Marti (:Paenglab)]

I hoped they merge it today before noon. I think, we land it when it's reviewed and a merge happened. When it doesn't work for FX, they have to fix it and we follow again, okay?

Comment 4

[Jorg K (CEST = GMT+2)]

Well, I reviewed it, but the question is whether you're going to send a new patch for IB and SM as well.

Comment 5

[Richard Marti (:Paenglab)]

Well, IB and SM don't have the needed icons to show in start menu (VisualElements_70.png and VisualElements_150.png together with the thunderbird.VisualElementsManifest.xml). So it makes not much sense to update them. They also don't have the previous code we exchange here.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8894797 [details] [diff] [review]
installer.patch

OK then. So you want this landed now after the next M-C merge, right?

Comment 7

[Richard Marti (:Paenglab)]

Up to you, you can also land it later as merge-fodder. We have no updated icon where it's needed to land immediately.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ea537b32d3f
Port bug 1291331 to TB [Update last modified time on start menu shortcuts during install or update]. r=jorgk