Closed
Bug 1388275
Opened 7 years ago
Closed 7 years ago
Remove nsIPrefBranch2 and nsIPrefBranchInternal in DOMi
Categories
(Other Applications :: DOM Inspector, enhancement, P3)
Tracking
(seamonkey2.54 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
seamonkey2.54 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
5.32 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1374847 +++ nsIPrefBranch2 and nsIPrefBranchInternal are both trivial subclasses of nsIPrefBranch which exist purely for add-on compatibility.
Assignee | ||
Comment 1•7 years ago
|
||
Version upgrades to current supported levels (which I think should not go beyond Fx 56). Tested with older SeaMonkey and TB versions too.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8894804 -
Flags: review?(iann_bugzilla)
Comment on attachment 8894804 [details] [diff] [review] 1388275-pref2.patch LGTM r=me
Attachment #8894804 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 3•7 years ago
|
||
I thought I needed to set the minimum Gecko versions too but doesn't look this way. https://hg.mozilla.org/dom-inspector/rev/fd6400256ecdb7df0ff66675e51a6dec9088478f https://hg.mozilla.org/dom-inspector/rev/9b13e3ad66cf993b30ba6e40e144a7d6428f43c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•