Closed Bug 1388288 Opened 2 years ago Closed 2 years ago

Make playback/webaudio code in dom/media build in non-Unified mode

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(7 files)

To assist in importing Gecko's media stack into Servo, we should make dom/media/ compile in non-Unified mode.
Comment on attachment 8894830 [details]
Bug 1388288 - Make EME/GMP related code build non-Unified.

https://reviewboard.mozilla.org/r/165972/#review171114
Attachment #8894830 - Flags: review?(gsquelart) → review+
Comment on attachment 8894829 [details]
Bug 1388288 - Make OpusTrackEncoder build in non-Unified mode.

https://reviewboard.mozilla.org/r/165970/#review171116
Attachment #8894829 - Flags: review?(bvandyk) → review+
Comment on attachment 8894825 [details]
Bug 1388288 - Make CubebUtils build in non-Unified builds.

https://reviewboard.mozilla.org/r/165962/#review171126
Attachment #8894825 - Flags: review?(padenot) → review+
Comment on attachment 8894826 [details]
Bug 1388288 - Make dom/media/webaudio build non-Unified.

https://reviewboard.mozilla.org/r/165964/#review171128
Attachment #8894826 - Flags: review?(padenot) → review+
Comment on attachment 8894828 [details]
Bug 1388288 - Make Flac and Ogg decoders build in non-Unified mode.

https://reviewboard.mozilla.org/r/165968/#review171152

::: dom/media/flac/FlacFrameParser.cpp:8
(Diff revision 1)
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "FlacFrameParser.h"
> +#include "FlacDemuxer.h"

The flac demuxer should depends on the frame parser, not the other way round....
Attachment #8894828 - Flags: review?(jyavenard) → review+
Comment on attachment 8894827 [details]
Bug 1388288 - Make dom/media/platforms build in non-unified mode.

https://reviewboard.mozilla.org/r/165966/#review171154

Please, make the new include so that they are in Alphabetical order. Thanks

::: dom/media/platforms/agnostic/gmp/GMPVideoDecoder.cpp:15
(Diff revision 1)
>  #include "MediaData.h"
>  #include "VPXDecoder.h"
>  #include "mozilla/EndianUtils.h"
>  #include "prsystem.h"
>  #include "mp4_demuxer/AnnexB.h"
> +#include "MP4Decoder.h"

Alphabetical order
Attachment #8894827 - Flags: review?(jyavenard) → review+
FYI, the errors in TrackBuffersManager.cpp when built in non-Unified mode are:

TrackBuffersManager.cpp(258): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(258): error C2065: 'WAITING_FOR_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(650): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(650): error C2065: 'WAITING_FOR_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(653): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(653): error C2065: 'PARSING_INIT_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(663): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(663): error C2065: 'PARSING_MEDIA_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(695): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(695): error C2065: 'PARSING_INIT_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(704): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(704): error C2065: 'PARSING_MEDIA_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(1166): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(1166): error C2065: 'WAITING_FOR_SEGMENT': undeclared identifier
TrackBuffersManager.cpp(1419): error C2653: 'AppendState': is not a class or namespace name
TrackBuffersManager.cpp(1419): error C2065: 'WAITING_FOR_SEGMENT': undeclared identifier
Do we have a meta bug to track all bugs required to port media stack to Servo?
Blocks: servo-media
(In reply to JW Wang [:jwwang] [:jw_wang] from comment #15)
> Do we have a meta bug to track all bugs required to port media stack to
> Servo?

I have filed Bug 1388605.
Comment on attachment 8894831 [details]
Bug 1388288 - Make TrackBuffersManager compile in non-Unified mode.

https://reviewboard.mozilla.org/r/165974/#review171608
Attachment #8894831 - Flags: review?(jyavenard) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5baca9a839d
Make CubebUtils build in non-Unified builds. r=padenot
https://hg.mozilla.org/integration/autoland/rev/df38d825cf4f
Make dom/media/webaudio build non-Unified. r=padenot
https://hg.mozilla.org/integration/autoland/rev/74a5b8b6715f
Make dom/media/platforms build in non-unified mode. r=jya
https://hg.mozilla.org/integration/autoland/rev/4c166d879019
Make Flac and Ogg decoders build in non-Unified mode. r=jya
https://hg.mozilla.org/integration/autoland/rev/b424022c9962
Make OpusTrackEncoder build in non-Unified mode. r=SingingTree
https://hg.mozilla.org/integration/autoland/rev/9c5d7cc84c4f
Make EME/GMP related code build non-Unified. r=gerald
https://hg.mozilla.org/integration/autoland/rev/44619504c9ee
Make TrackBuffersManager compile in non-Unified mode. r=jya
Blocks: 1390617
You need to log in before you can comment on or make changes to this bug.