[compare-locales] python 3 support

NEW
Unassigned

Status

Localization Infrastructure and Tools
compare-locales
3 months ago
3 months ago

People

(Reporter: Pike, Unassigned)

Tracking

(Blocks: 1 bug)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Reporter)

Description

3 months ago
compare-locales should support py3, via six.

Just 3.6+ is good enough.
(Reporter)

Updated

3 months ago
Assignee: nobody → l10n
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 6

3 months ago
I'm throwing this fish back into the pond.

It's way more work than I anticipated, and not really urgent.

Attaching the status quo of my patch queue. This passes the tests on both py27 and py36, but that's probably mostly due to the lack of tests that stress the difference between bytes and unicode. The current mainline has just encode and decode sprinkled all over it, and there's just no design what's unicode and what's not.

That needs fixing, and way more tests to ensure that behavior.

Which leads me to be not particularly happy with the byte/string/unicode patch in this queue. It's also just randomly sprinkling unicode_literals and b'', but again without intent and design.
Assignee: l10n → nobody
You need to log in before you can comment on or make changes to this bug.