1388333 - UnicodeEncodeError in signature report

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

https://sentry.prod.mozaws.net/operations/socorro-prod/issues/635928/

Gone are the days when we could (actually, we never could but ignored it) assume that all signatures were only using ascii characters.

Comment 1

[Peter Bengtsson [:peterbe]]

Actually, the UnicodeEncodeError happened because the query string `accessibility` was a unicode string. Not the signature.

Comment 2

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla-services/socorro/pull/3893

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

The traceback is this:

"""
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-59: ordinal not in range(128)
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 499, in wrapper
    return wrapped(*args, **kwargs)
  File "csp/decorators.py", line 19, in _wrapped
    r = f(*a, **kw)
  File "crashstats/signature/views.py", line 49, in inner
    params = get_params(request)
  File "crashstats/supersearch/views.py", line 85, in get_params
    if not form.is_valid():
  File "django/forms/forms.py", line 184, in is_valid
    return self.is_bound and not self.errors
  File "django/forms/forms.py", line 176, in errors
    self.full_clean()
  File "django/forms/forms.py", line 392, in full_clean
    self._clean_fields()
  File "django/forms/forms.py", line 407, in _clean_fields
    value = field.clean(value)
  File "django/forms/fields.py", line 162, in clean
    value = self.to_python(value)
  File "crashstats/supersearch/form_fields.py", line 183, in to_python
    if str(value).lower() in ('__true__', 'true', 't', '1', 'y', 'yes'):
"""

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/10c9b556de5f869670b636d1eb245f08ca2ca8fd
fixes bug 1388333 - UnicodeEncodeError in signature report (#3893)

* fixes bug 1388333 - UnicodeEncodeError in signature report

* tidying up

Comment 5

[Peter Bengtsson [:peterbe]]

Doesn't happen any more.
https://crash-stats.allizom.org/signature/?product=Firefox&version=56.0b&accessibility=__tr%C3%B6e__&signature=shutdownhang%20|%20ZwWaitForKeyedEvent%20|%20RtlSleepConditionVariableCS%20|%20SleepConditionVariableCS&date=%3E%3D2017-08-08T14%3A41%3A15.000Z&date=%3C2017-08-15T14%3A41%3A15.000Z

(&accessibility=__tröe_)