Closed Bug 1388365 Opened 2 years ago Closed 2 years ago

Upgrade to webdriver 0.29.0

Categories

(Testing :: geckodriver, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(7 files)

webdriver 0.29.0 was just released today.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171250

::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:40
(Diff revision 1)
>              pass
>  
>      session.window_handle = current_window
>  
>  
> +def _return_window_to_normal_state(session):

I would call it `restore_normal_window_state`.

::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:156
(Diff revision 1)
>  
>      # finalisers are popped off a stack,
>      # making their ordering reverse
>      request.addfinalizer(lambda: _switch_to_top_level_browsing_context(_current_session))
>      request.addfinalizer(lambda: _restore_windows(_current_session))
> +    request.addfinalizer(lambda: _return_window_to_normal_state(_current_session))

Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized.
Attachment #8894897 - Flags: review?(hskupin) → review-
Comment on attachment 8894898 [details]
Bug 1388365 - Add client.Window#state and #rect.

https://reviewboard.mozilla.org/r/166054/#review171254

::: commit-message-c123b:4
(Diff revision 1)
> +Bug 1388365 - Add client.Window#state and #rect. r?whimboo
> +
> +Introduces two new APIs on client.Window in the WPT WebDriver client.
> +rect, and #rect is used to reduce raw calls to GET window/rect.

Hm, what is `rect` in this context?
Attachment #8894898 - Flags: review?(hskupin) → review+
Comment on attachment 8894899 [details]
Bug 1388365 - Add minimize and fullscreen to client.Window.

https://reviewboard.mozilla.org/r/166056/#review171256
Attachment #8894899 - Flags: review?(hskupin) → review+
Comment on attachment 8894900 [details]
Bug 1388365 - Return value from assert_success.

https://reviewboard.mozilla.org/r/166058/#review171258

::: commit-message-9c933:4
(Diff revision 1)
> +Bug 1388365 - Return value from assert_success. r?whimboo
> +
> +Return the contents of value, if it exists, after asserting the response
> +was successful.

The description here is just the code. Can you please explain why this is necessary? It's not clear to me.
Attachment #8894900 - Flags: review?(hskupin) → review+
Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171250

> I would call it `restore_normal_window_state`.

That is a better name, thanks.

> Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized.

Yes.
Comment on attachment 8894900 [details]
Bug 1388365 - Return value from assert_success.

https://reviewboard.mozilla.org/r/166058/#review171258

> The description here is just the code. Can you please explain why this is necessary? It's not clear to me.

assert_success can be passed a value which will assert that the response's
value matches an expected value.  If you want to compare a subsection
of the response it may be convenient to for the value to be returned
after it has been asserted that the response was a success.

I’ve included this in the commit message.
Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171588
Attachment #8894897 - Flags: review?(hskupin) → review+
Given that Andreas is out the next days I'm going to push this patch series now to unblock myself for proxy related work.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/535e76277207
Upgrade to webdriver 0.29.0. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/ec1bd26e8184
Vendor webdriver 0.29.0. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/65dc7d28c6fc
Return window to normal state. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/4cecb03e8236
Add client.Window#state and #rect. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/54f45fe718c5
Add minimize and fullscreen to client.Window. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/4e7e4ae3cac6
Return value from assert_success. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/17421285e3a2
Test window rect state. r=whimboo
You need to log in before you can comment on or make changes to this bug.