1388365 - Upgrade to webdriver 0.29.0

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

webdriver 0.29.0 was just released today.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Upgrade to webdriver 0.29.0.

Upgrades the webdriver crate dependency to 0.29.0, which contains some
backwards incompatible changes for RectResponse.  This type has been
split in two, WindowRectResponse and ElementRectResponse.

The former type contains a new "state" field which is already implemented
by Marionette.  Because geckodriver is used with a range of earlier
Firefoxen, it defaults to "normal" window state if the field is not
returned from Marionette.  This is acceptable.

Review commit: https://reviewboard.mozilla.org/r/166048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166048/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Vendor webdriver 0.29.0.

Review commit: https://reviewboard.mozilla.org/r/166050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166050/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Return window to normal state.

If a test leaves the window in maximized, minimized, or fullscreen
state it should be returned to the normal state the next time a session
is requested.

Review commit: https://reviewboard.mozilla.org/r/166052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166052/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Add client.Window#state and #rect.

Introduces two new APIs on client.Window in the WPT WebDriver client.
rect, and #rect is used to reduce raw calls to GET window/rect.

Review commit: https://reviewboard.mozilla.org/r/166054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166054/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Add minimize and fullscreen to client.Window.

Review commit: https://reviewboard.mozilla.org/r/166056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166056/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Return value from assert_success.

Return the contents of value, if it exists, after asserting the response
was successful.

Review commit: https://reviewboard.mozilla.org/r/166058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166058/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1388365 - Test window rect state.

Review commit: https://reviewboard.mozilla.org/r/166060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166060/

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894895 [details]
Bug 1388365 - Upgrade to webdriver 0.29.0.

https://reviewboard.mozilla.org/r/166048/#review171226

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894896 [details]
Bug 1388365 - Vendor webdriver 0.29.0.

https://reviewboard.mozilla.org/r/166050/#review171234

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171250

::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:40
(Diff revision 1)
>              pass
>  
>      session.window_handle = current_window
>  
>  
> +def _return_window_to_normal_state(session):

I would call it `restore_normal_window_state`.

::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:156
(Diff revision 1)
>  
>      # finalisers are popped off a stack,
>      # making their ordering reverse
>      request.addfinalizer(lambda: _switch_to_top_level_browsing_context(_current_session))
>      request.addfinalizer(lambda: _restore_windows(_current_session))
> +    request.addfinalizer(lambda: _return_window_to_normal_state(_current_session))

Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894898 [details]
Bug 1388365 - Add client.Window#state and #rect.

https://reviewboard.mozilla.org/r/166054/#review171254

::: commit-message-c123b:4
(Diff revision 1)
> +Bug 1388365 - Add client.Window#state and #rect. r?whimboo
> +
> +Introduces two new APIs on client.Window in the WPT WebDriver client.
> +rect, and #rect is used to reduce raw calls to GET window/rect.

Hm, what is `rect` in this context?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894899 [details]
Bug 1388365 - Add minimize and fullscreen to client.Window.

https://reviewboard.mozilla.org/r/166056/#review171256

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894900 [details]
Bug 1388365 - Return value from assert_success.

https://reviewboard.mozilla.org/r/166058/#review171258

::: commit-message-9c933:4
(Diff revision 1)
> +Bug 1388365 - Return value from assert_success. r?whimboo
> +
> +Return the contents of value, if it exists, after asserting the response
> +was successful.

The description here is just the code. Can you please explain why this is necessary? It's not clear to me.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894901 [details]
Bug 1388365 - Test window rect state.

https://reviewboard.mozilla.org/r/166060/#review171262

Comment 15

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171250

> I would call it `restore_normal_window_state`.

That is a better name, thanks.

> Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized.

Yes.

Comment 16

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894900 [details]
Bug 1388365 - Return value from assert_success.

https://reviewboard.mozilla.org/r/166058/#review171258

> The description here is just the code. Can you please explain why this is necessary? It's not clear to me.

assert_success can be passed a value which will assert that the response's
value matches an expected value.  If you want to compare a subsection
of the response it may be convenient to for the value to be returned
after it has been asserted that the response was a success.

I’ve included this in the commit message.

Comment 17

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166052/diff/1-2/

Comment 18

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894898 [details]
Bug 1388365 - Add client.Window#state and #rect.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166054/diff/1-2/

Comment 19

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894899 [details]
Bug 1388365 - Add minimize and fullscreen to client.Window.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166056/diff/1-2/

Comment 20

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894900 [details]
Bug 1388365 - Return value from assert_success.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166058/diff/1-2/

Comment 21

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8894901 [details]
Bug 1388365 - Test window rect state.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166060/diff/1-2/

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8894897 [details]
Bug 1388365 - Return window to normal state.

https://reviewboard.mozilla.org/r/166052/#review171588

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Given that Andreas is out the next days I'm going to push this patch series now to unblock myself for proxy related work.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535e76277207
Upgrade to webdriver 0.29.0. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/ec1bd26e8184
Vendor webdriver 0.29.0. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/65dc7d28c6fc
Return window to normal state. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/4cecb03e8236
Add client.Window#state and #rect. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/54f45fe718c5
Add minimize and fullscreen to client.Window. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/4e7e4ae3cac6
Return value from assert_success. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/17421285e3a2
Test window rect state. r=whimboo

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/535e76277207
https://hg.mozilla.org/mozilla-central/rev/ec1bd26e8184
https://hg.mozilla.org/mozilla-central/rev/65dc7d28c6fc
https://hg.mozilla.org/mozilla-central/rev/4cecb03e8236
https://hg.mozilla.org/mozilla-central/rev/54f45fe718c5
https://hg.mozilla.org/mozilla-central/rev/4e7e4ae3cac6
https://hg.mozilla.org/mozilla-central/rev/17421285e3a2