1388368 - The Console panel is broken in Launchpad

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It isn't possible to load the Console panel on top of the Launchpad. And there are following error messages when `yarn start` is executed.

We might need some new shims for the Launchpad.

Honza

---

ERROR in ./local-dev/index.js
Module not found: Error: Cannot resolve 'file' or 'directory' ../../themes/new-w
ebconsole.css in C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\l
ocal-dev
 @ ./local-dev/index.js 24:0-42

ERROR in ./new-webconsole.js
Module not found: Error: Cannot resolve module 'devtools/client/shared/key-short
cuts' in C:\src\mozilla.org\mozilla-central\devtools\client\webconsole
 @ ./new-webconsole.js 17:21-68

ERROR in ./new-webconsole.js
Module not found: Error: Cannot resolve module 'devtools/shared/system' in C:\sr
c\mozilla.org\mozilla-central\devtools\client\webconsole
 @ ./new-webconsole.js 19:15-48

ERROR in ./new-webconsole.js
Module not found: Error: Cannot resolve module 'devtools/client/shared/zoom-keys
' in C:\src\mozilla.org\mozilla-central\devtools\client\webconsole
 @ ./new-webconsole.js 20:21-64

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1388368 - Fix the Console panel in Launchpad;

Review commit: https://reviewboard.mozilla.org/r/166514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166514/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166514/diff/1-2/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Nicolas: can you please check out the attached patch?
I am seeing some problems with Launchpad CSS

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This PR is needed:
https://github.com/devtools-html/devtools-core/pull/573

Honza

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I do see the CSS issue in the launchpad as well.
It seems to be missing the css variables file

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166514/diff/2-3/

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Fixed.

Not sure how much work it is to load webconsole.xhtml directly, but it could be a follow up perhaps.

Honza

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

https://reviewboard.mozilla.org/r/166514/#review171686

Looks good to me, one small comment but this does not prevent the launchpad from working.
Thanks for taking care of this Honza

::: devtools/client/webconsole/local-dev/jsterm-stub.js:175
(Diff revision 3)
> +  focus() {
> +  },

This is fine now, but I think this could simply be `this.inputNode.focus()` doesn't it ?

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166514/diff/3-4/

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)
> This is fine now, but I think this could simply be `this.inputNode.focus()`
Good point, done.

Honza

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166514/diff/4-5/

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I've yet changed the way how KeyShortcuts object is exported
Related PR: https://github.com/devtools-html/devtools-core/pull/577

Honza

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2e76a2d8794
Fix the Console panel in Launchpad; r=nchevobbe

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for eslint failures in system-stub.js (should be Unix linebreaks, not the Windows' ones):

https://hg.mozilla.org/integration/autoland/rev/0dbe24ac3a2ffb28b2f1425f97186a1fb531f5ae

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d2e76a2d879484f477dee19958e57d6faea136de&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121999580&repo=autoland

Comment 15

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8895311 [details]
Bug 1388368 - Fix the Console panel in Launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166514/diff/5-6/

Comment 16

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorry, try is green now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da43610a2f1c

Honza

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a4bcb6c0d16
Fix the Console panel in Launchpad; r=nchevobbe

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a4bcb6c0d16