Closed Bug 1388377 Opened 7 years ago Closed 7 years ago

Activity Stream: Update highlights welcome/empty message

Categories

(Firefox for Android Graveyard :: General, enhancement, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
enhancement

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: sebastian, Assigned: mcomella)

References

Details

(Whiteboard: [MobileAS])

Attachments

(5 files, 1 obsolete file)

as-welcome.png
247.02 KB, image/png
Details
New Tab - Pocket Stories No Highlights@2x.png
274.40 KB, image/png
Details
Screenshot post-patch
99.82 KB, image/png
Details
Bug 1388377: Rm WelcomePanelRow.
59 bytes, text/x-review-board-request
liuche
: review+
Details
Bug 1388377: Add highlights empty state.
59 bytes, text/x-review-board-request
liuche
: review+
Details
Attached image as-welcome.png — 
When displaying the Activity Stream panel for the first time we show a "welcome" message until the user explicitly dismisses it (see screenshot).

As far as I remember we wanted to remove it (or replace it?).
Bryan, Aaron: What should we do here?
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Or related: How should the empty state look like (= No highlights). Should I file a separate bug for that?
(In reply to Sebastian Kaspari (:sebastian) from comment #0)
> Created attachment 8894885 [details]
> as-welcome.png
> 
> When displaying the Activity Stream panel for the first time we show a
> "welcome" message until the user explicitly dismisses it (see screenshot).
> 
> As far as I remember we wanted to remove it (or replace it?).

that message should only show if we have no highlights to show during a first run. users should have to press any buttons. 

Also we removed the fox in iOS, so let's do that now.
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
During the Pocket meeting, we discussed adding a new string here to introduce both Pocket and Highlights. This would need strings from Michelle, after UX comes up with mocks/intent of the string.
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Summary: Activity Stream: Remove our update welcome message → Activity Stream: Update welcome message
From bug 1390542: We need to make sure that this message is shown whenever there are no highlights available.
Attached image Highlights Zero State (minus fox) (obsolete) — 
Can remove the fox and adjust the layout slightly as seen in the mockup. Text should change to match our zero-state on desktop:

-----
Start browsing, and we'll show some of the great articles, videos, and other pages you’ve recently visited or bookmarked here.
-----
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Assignee: nobody → michael.l.comella
This bug is based off the code from the other bug: I split the String activity_stream_welcome_dismiss from activity_stream_dismiss.
Depends on: 1315201
Iteration: --- → 1.28
Priority: P2 → P1
Aaron, just checking - during the Pocket meeting today bbell said that this Welcome message should show up right below Top Sites, above Pocket and Highlights. That's a little conflicting with this mock, so can you clarify where it should be? Also, this message doesn't really talk about Pocket - is the plan to have another message that deals with Pocket, or are these strings outdated?
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Might conflict with liuche's changes and due to liuche's question, I'll find something else in the meantime.
Assignee: michael.l.comella → nobody
Iteration: 1.28 → 1.29
From meeting w/ bbell, some open questions:

- What is the actual positioning of this Welcome message? Is it above Pocket/Highlights as discussed in Pocket meeting, or is it only an empty state for Highlights?
- When does this view show, and when does it go away? (is it an empty state, or does it persist until people click the "Okay" button?)

We need to make sure NOT to miss string freeze for this!
The message should show up only in the Highlights position when there aren't any Highlights to show yet. We can get ride of the "OKAY" button since it was only meant as a means to dismiss the message and it was causing some confusion. We're also not showing any explainer for Pocket stories as those should just show up right away and don't really need an explainer. 

Message text:
Start browsing, and we'll show some of the great articles, videos, and other pages you’ve recently visited or bookmarked here.
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Assignee: nobody → michael.l.comella
Comment on attachment 8899944 [details]
Highlights Zero State (minus fox)

Obsoleting old design.
Attachment #8899944 - Attachment is obsolete: true
Summary: Activity Stream: Update welcome message → Activity Stream: Update highlights welcome/empty message
Comment on attachment 8903360 [details]
Bug 1388377: Rm WelcomePanelRow.

https://reviewboard.mozilla.org/r/175162/#review180268
Attachment #8903360 - Flags: review?(liuche) → review+
Comment on attachment 8903361 [details]
Bug 1388377: Add highlights empty state.

https://reviewboard.mozilla.org/r/175164/#review180270

::: mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/StreamRecyclerAdapter.java:303
(Diff revision 1)
>          return recyclerViewModel.size();
>      }
>  
>      public void swapHighlights(List<Highlight> highlights) {
>          recyclerViewModel = recyclerViewModel.subList(0, FIXED_ROWS.length + getNumOfTypeShown(RowItemType.TOP_STORIES_ITEM));
> +        if (!highlights.isEmpty()) {

Nice sequestering this inside of the highlights handling.
Attachment #8903361 - Flags: review?(liuche) → review+
Due to code conflicts.
Depends on: 1386735
Backout by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3da77a7e896c
Backed out changeset 512562477a1e, c5b310c419c4 for Android build bustage
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: