Closed Bug 1388412 Opened 2 years ago Closed 2 years ago

[dt-addon] udpate devtools install.rdf to support Thunderbird, Seamonkey...

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Initial landing of Bug 1369801 broken the xpcshell tests for Thunderbird. 

See the discussion in bug 1384871 for potential fixes proposed:
- use the toolkit em:id https://bugzilla.mozilla.org/show_bug.cgi?id=1384871#c8
- add one entry per application https://bug1384871.bmoattachments.org/attachment.cgi?id=8892399 

This needs to be resolved before attempting to re-land Bug 1369801. I want to try Philipp's proposal to use only the toolkit em:id as it would simplify maintenance on our side.
Priority: -- → P3
Try push with the addon patches + this modification: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ba9d74a29c75a768ef47a33fe74c3d4fd7f7c53
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
xpcshell test failures are unrelated and will be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1396571
Attachment #8904230 - Flags: review?(poirot.alex)
Comment on attachment 8904230 [details]
Bug 1388412 - update devtools addon install rdf to use toolkit em:id;

https://reviewboard.mozilla.org/r/176008/#review181064

::: devtools/install.rdf:24
(Diff revision 1)
>      <em:multiprocessCompatible>true</em:multiprocessCompatible>
> +    <!-- Valid for all toolkit applications -->
>      <em:targetApplication>
>        <Description>
> -        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
> -        <em:minVersion>44.0a1</em:minVersion>
> +        <em:id>toolkit@mozilla.org</em:id>
> +        <em:minVersion>0</em:minVersion>

If I remember correctly, toolkit@mozilla.org follows platform/gecko version, so you should be able to use: 57.0a1 as minVersion rather than uncommon zero.
Attachment #8904230 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #4)
> Comment on attachment 8904230 [details]
> Bug 1388412 - update devtools addon install rdf to use toolkit em:id;
> 
> https://reviewboard.mozilla.org/r/176008/#review181064
> 
> ::: devtools/install.rdf:24
> (Diff revision 1)
> >      <em:multiprocessCompatible>true</em:multiprocessCompatible>
> > +    <!-- Valid for all toolkit applications -->
> >      <em:targetApplication>
> >        <Description>
> > -        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
> > -        <em:minVersion>44.0a1</em:minVersion>
> > +        <em:id>toolkit@mozilla.org</em:id>
> > +        <em:minVersion>0</em:minVersion>
> 
> If I remember correctly, toolkit@mozilla.org follows platform/gecko version,
> so you should be able to use: 57.0a1 as minVersion rather than uncommon zero.

Ok I'll land with 57.0a1 and we will see if it causes any issue for SeaMonkey's weird versioning scheme.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b755ebe73d6
update devtools addon install rdf to use toolkit em:id;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/0b755ebe73d6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.