Closed Bug 1388433 Opened 2 years ago Closed 2 years ago

5,900 instances of "Unable to untransform dirty rect!" emitted from layout/generic/nsFrame.cpp during linux64 debug testing

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: erahm, Assigned: kats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 5930 WARNING: Unable to untransform dirty rect!: file layout/generic/nsFrame.cpp, line 2460

This warning [1] shows up in the following test suites:

>   1454 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>   1291 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>    795 - test-linux64/debug-mochitest-e10s-3 3
>    617 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>    507 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>    458 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>    193 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>    137 - test-linux64/debug-mochitest-e10s-5 5
>    120 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>     89 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     81 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     72 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     57 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>     12 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     11 - test-linux64/debug-mochitest-e10s-7 7
>      7 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>      6 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>      5 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>      4 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>      3 - test-linux64/debug-mochitest-clipboard-e10s cl
>      3 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>      2 - test-linux64/debug-reftest-e10s-8 R8
>      2 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>      2 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>      1 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>      1 - test-linux64/debug-crashtest-e10s C

It shows up in 113 tests. A few of the most prevalent:

>   1039 - [e10s] browser/base/content/test/general/browser_contentSearchUI.js
>    502 - [e10s] browser/base/content/test/urlbar/browser_tabMatchesInAwesomebar.js
>    472 - [e10s] devtools/client/webconsole/test/browser_webconsole_bug_752559_ineffective_iframe_sandbox_warning.js
>    432 - [e10s] browser/components/sessionstore/test/browser_586068-reload.js
>    350 - [e10s] dom/html/test/test_iframe_sandbox_navigation2.html
>    318 - [e10s] dom/html/test/test_iframe_sandbox_popups_inheritance.html
>    279 - [e10s] browser/components/sessionstore/test/browser_586068-window_state.js
>    233 - [e10s] browser/base/content/test/general/browser_relatedTabs.js
>    215 - [e10s] browser/components/sessionstore/test/browser_586068-multi_window.js
>    200 - [e10s] browser/components/sessionstore/test/browser_906076_lazy_tabs.js

[1] https://hg.mozilla.org/mozilla-central/annotate/8c7788eda00e/layout/generic/nsFrame.cpp#l2460
Priority: -- → P3
Kats: can we lose this warning or assert that the transform is singular instead?

https://hg.mozilla.org/mozilla-central/diff/5ff928574d65/layout/generic/nsFrame.cpp
Flags: needinfo?(bugmail)
I think based on bug 984460 comment 60 the singular-transform case is actually handled fine, and we can just drop the warning.
Assignee: nobody → bugmail
Flags: needinfo?(bugmail)
Comment on attachment 8906639 [details]
Bug 1388433 - Remove unnecessary warning as the codepath is handled in an acceptable manner.

https://reviewboard.mozilla.org/r/178354/#review183324
Attachment #8906639 - Flags: review?(matt.woodrow) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a31654a23d3
Remove unnecessary warning as the codepath is handled in an acceptable manner. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/1a31654a23d3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.