|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Tabs don't seem to be activatable any more as well as there's no keyboard focus highlighting.
Whiteboard: [photon-preference] → [photon-preference][triage]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Target Milestone: --- → Firefox 57
This issue caused by visual change since background color is lighter. Focus ring is also white color so it's hard to tell by eyes. After discussion with Helen, we've agreed that to change `--in-content-category-border-focus` to `1px dotted #45a1ff` for fixing this visual issue.
Created attachment 8896827 [details] key-navigation-focus-color.png Here is the current keyboard navigation focus color.
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try searching for changes remote: abort: abandoned transaction found! remote: (run 'hg recover' to clean up transaction) abort: stream ended unexpectedly (got 0 bytes, expected 4)
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try searching for changes remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '30058' on host 'hgssh4.dmz.scl3.mozilla.com/effffffc' remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by 'hgssh4.dmz.scl3.mozilla.com/effffffc:4150' abort: stream ended unexpectedly (got 0 bytes, expected 4)
Comment on attachment 8895318 [details] Bug 1388444 - Make about:preferences category focus color noticeable https://reviewboard.mozilla.org/r/166530/#review173498 r=me with the color changed to 0a84ff ::: toolkit/themes/shared/in-content/common.inc.css:25 (Diff revision 4) > --in-content-item-hover: rgba(0,149,221,0.25); > --in-content-item-selected: #0a84ff; > --in-content-border-highlight: #0a84ff; > --in-content-border-focus: #0a84ff; > --in-content-border-color: #c1c1c1; > + --in-content-category-border-focus: 1px dotted #45a1ff; We use #0a84ff for --in-content-category-text-selected. #0a84ff is the correct color to be used with dark text, as seen by https://hg.mozilla.org/mozilla-central/diff/bdc9b689b8b3/browser/themes/shared/toolbarbutton-icons.inc.css Can you please file a bug to change the in-content color usages of #45a1ff to #0a84ff?
Attachment #8895318 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ee09f4253ae1 Make about:preferences category focus color noticeable r=jaws
> Can you please file a bug to change the in-content color usages of #45a1ff > to #0a84ff? I've followed your request and changed the color of --in-content-category-border-focus to #0a84ff along with last patch update. Thanks
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Build ID: 20170816100153 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.