Left hand side tabs are not keyboard accessible.

VERIFIED FIXED in Firefox 57

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: yzen, Assigned: rickychien)

Tracking

(Blocks 1 bug, {access})

unspecified
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-preference])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Tabs don't seem to be activatable any more as well as there's no keyboard focus highlighting.
Whiteboard: [photon-preference] → [photon-preference][triage]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Blocks: 1357306
Target Milestone: --- → Firefox 57
Comment hidden (mozreview-request)
This issue caused by visual change since background color is lighter. Focus ring is also white color so it's hard to tell by eyes.

After discussion with Helen, we've agreed that to change `--in-content-category-border-focus` to `1px dotted #45a1ff` for fixing this visual issue.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Here is the current keyboard navigation focus color.

Comment 7

2 years ago
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: abort: abandoned transaction found!
remote: (run 'hg recover' to clean up transaction)
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 8

2 years ago
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '30058' on host 'hgssh4.dmz.scl3.mozilla.com/effffffc'
remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by 'hgssh4.dmz.scl3.mozilla.com/effffffc:4150'
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8895318 [details]
Bug 1388444 - Make about:preferences category focus color noticeable

https://reviewboard.mozilla.org/r/166530/#review173498

r=me with the color changed to 0a84ff

::: toolkit/themes/shared/in-content/common.inc.css:25
(Diff revision 4)
>    --in-content-item-hover: rgba(0,149,221,0.25);
>    --in-content-item-selected: #0a84ff;
>    --in-content-border-highlight: #0a84ff;
>    --in-content-border-focus: #0a84ff;
>    --in-content-border-color: #c1c1c1;
> +  --in-content-category-border-focus: 1px dotted #45a1ff;

We use #0a84ff for --in-content-category-text-selected.

#0a84ff is the correct color to be used with dark text, as seen by https://hg.mozilla.org/mozilla-central/diff/bdc9b689b8b3/browser/themes/shared/toolbarbutton-icons.inc.css

Can you please file a bug to change the in-content color usages of #45a1ff to #0a84ff?
Attachment #8895318 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 11

2 years ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee09f4253ae1
Make about:preferences category focus color noticeable r=jaws
> Can you please file a bug to change the in-content color usages of #45a1ff
> to #0a84ff?

I've followed your request and changed the color of --in-content-category-border-focus to #0a84ff along with last patch update.

Thanks

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee09f4253ae1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 14

2 years ago
Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.