Closed Bug 1388448 Opened 6 years ago Closed 6 years ago

Add logs for better overall network request/context tracking

Categories

(Core :: Networking, enhancement)

Product:
Core
Component:
Networking
Version:
56 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

v1 (just adds few logs, simple)
23.23 KB, patch
dragana
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch backup1 (obsolete) — — Splinter Review 

    
  
Whiteboard: [necko-active]

    
    

    
  


  
This is needed to track request context, page loads and channels in logan [1] for network diagnostics/breakdown within a page load.

Regarding the nsDocument logs, there are few more than just ctor and dtor already and those are there since stone age.  I don't assume there would be any analytic tool that could break ;)  I believe the same applies to PresShell logs.

[1] https://janbambas.cz/moz/logan/

        Attachment #8895002 -
        Attachment is obsolete: true

        Attachment #8898426 -
        Flags: review?(jduell.mcbugs)

    
    

    
  
Comment on attachment 8898426 [details] [diff] [review]
v1 (just adds few logs, simple)

No reaction from Jason...   Dragana, this is a simple patch, nothing more than added LOGs.  Thanks.

        Attachment #8898426 -
        Flags: review?(jduell.mcbugs) → review?(dd.mozilla)

        Attachment #8898426 -
        Flags: review?(dd.mozilla) → review+

    
    

    
  
Thanks.
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/464568af8eb1
Logs for better network requests and context tracking. r=mcmanus
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/464568af8eb1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox57:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

          You need to log in
          before you can comment on or make changes to this bug.