Bug 1388464: Use SyncRunnable instead of DISPATCH_SYNC to actually block the main thread during the blocking preference file write.
59 bytes, text/x-review-board-request
See 1386263. The goal of the sync pref file save off the main thread was to block the main thread until the work is done, not to allow an event loop to spin which is allowed to process other events.
We are using nsIEventTarget::Dispatch with DISPATCH_SYNC flag. We should have been using SyncRunnable::DispatchToThread instead.
Comment on attachment 8895073 [details] Bug 1388464: Use SyncRunnable instead of DISPATCH_SYNC to actually block the main thread during the blocking preference file write. https://reviewboard.mozilla.org/r/166198/#review171466
Attachment #8895073 - Flags: review?(bugs) → review+
NI Benjamin just to make sure he's seen this.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/6ffe8a4a92c7 Use SyncRunnable instead of DISPATCH_SYNC to actually block the main thread during the blocking preference file write. r=smaug
See Also: → bug 1384454
See Also: bug 1384454 →
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Didn't this code land for 56? I think this needs an uplift.
status-firefox56: --- → ?
tracking-firefox56: --- → ?
Indeed, but 56 has it disabled through a preference, so we shouldn't hit this codepath. But, yes, if we want to enable the off main thread preference write and on pref change auto save, we'd need this patch as well.
Track 56+ in case we will enable the pref.
tracking-firefox56: ? → +
This is still disabled by pref in 56, so 56 is unaffected.
status-firefox56: ? → unaffected
tracking-firefox56: + → ---
You need to log in before you can comment on or make changes to this bug.