Closed Bug 1388509 Opened 7 years ago Closed 7 years ago

sound indicator on pinned tabs is overlaying the favicon

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
57 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: philipp, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [photon-visual][p1])

Attachments

(2 files)

2017-08-08 22_31_52-.png
6.55 KB, image/png
Details
Bug 1388509 - Fix tab-icon-overlay alignment on pinned tabs.
59 bytes, text/x-review-board-request
daleharvey
: review+
Details 
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

after the photon theme landed on nightly audio indicators for pinned tabs are placed mid-center in the tab and therefore overlaying the tab's favicon (see screenshot).
this makes it more difficult to spot the right tab.
same thing as bug 1388516?
Whiteboard: [triage] → [photon-visual][triage]
Blocks: photon-tabs
Whiteboard: [photon-visual][triage] → [photon-visual][p1]
Flags: qe-verify?
Priority: -- → P1
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Comment on attachment 8895829 [details]
Bug 1388509 - Fix tab-icon-overlay alignment on pinned tabs.

https://reviewboard.mozilla.org/r/167122/#review172652

Much nicer, cheers
Attachment #8895829 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ded54fea4c6b
Fix tab-icon-overlay alignment on pinned tabs. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/ded54fea4c6b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this Bug on Nightly 57.0a1 (2017-08-07) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 57.0a1

Build ID :   20170814100258
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170809]
I have reproduced this bug with nightly 57.0a1 (2017-08-07) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 57.0a1

Build ID 	20170814100258
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

[Bugday-20170809]
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
Verified on Mac OS X 10.10, Windows 10, Windows 7 and Ubuntu 16.04 and I can confirm the fix. I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: