Remove stubbed out B2G only functions from gfx/gl/GLLibraryEGL.h

RESOLVED FIXED in Firefox 57

Status

()

P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: erahm, Assigned: ami.bugzilla)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Bug 1386825 is removing MOZ_B2G and makes the stubs in gfx/gl/GLLibraryEGL.h [1] effectively dead code. We should remove them and update any callers.

[1] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/gfx/gl/GLLibraryEGL.h#489-514
Priority: -- → P5
Whiteboard: gfx-noted
(Assignee)

Comment 1

2 years ago
Hi Jeff, I've already removed the code suggested by Eric, could you please review it? Thank you very much.
Attachment #8895210 - Flags: review?(jgilbert)
Comment on attachment 8895210 [details] [diff] [review]
Remove stubbed out B2G only functions

Review of attachment 8895210 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +345,5 @@
>      // Assume that EGL has the same problem as WGL does,
>      // where MakeCurrent with an already-current context is
>      // still expensive.
>      bool hasDifferentContext = false;
> +    if (mContext) {

mContext is always truthy. Since we don't need to check this anymore, we should simplify this logic.

This should be written as:
bool needsMakeCurrent;
if (aForce) {
    needsMakeCurrent = true;
} else {
    needsMakeCurrent = (sEGLLibrary.fGetCurrentContext() != mContext);
}

if (needsMakeCurrent) {
    EGLSurface...
Attachment #8895210 - Flags: review?(jgilbert) → review-
(Assignee)

Comment 3

2 years ago
Hi Jeff, I modified the patch according to your comment, would you please review again? Thank you.
Attachment #8895210 - Attachment is obsolete: true
Attachment #8896844 - Flags: review?(jgilbert)
Attachment #8896844 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

2 years ago
Hello, I don't why I cannot add the checkin-need keyword to this bug.
Can anyone help me please?
Assignee: nobody → ami.bugzilla
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7398e1677a1
Remove stubbed out B2G only functions. r=jgilbert
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c7398e1677a1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.