On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Tours
P3
normal
VERIFIED FIXED
10 months ago
8 months ago

People

(Reporter: Abe_LV, Assigned: Fischer)

Tracking

(Depends on: 1 bug)

57 Branch
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [photon-onboarding])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Steps to Reproduce:

Here is screen capture: https://testing-1.tinytake.com/sf/MTg1NDczOF81OTc3NjA4

1. Start the latest nightly from a clean profile
2. Create a new tab
3. Click on the Fox (New to Nightly?...)
4. Click on "Show Private Browsing in Menu" 
5. Minimize the browser size until the tour overlay disappears.
6. Click on the body of the browser or navigate to any site on that tab.
7. Verify the drop down menu disappears

Actual Result
The drop down menu does not disappear

Expected Result:
The drop down menu should disappear when the user clicks on another part of the page
(Reporter)

Updated

10 months ago
Flags: needinfo?(rexboy)

Updated

10 months ago
Whiteboard: [photon-onboarding]
I would suggest either cancel the highlight when resizing or webpage redirects.
(The letter one may be able to erase more corner cases like this?)
Putting on triage tag.
Flags: needinfo?(rexboy)
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]

Updated

10 months ago
Flags: qe-verify+
Priority: -- → P3
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]

Updated

9 months ago
Duplicate of this bug: 1392832
(Assignee)

Comment 3

9 months ago
Update the bug title because we not only handle *resize* but also *unload* case.
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Summary: On boarding (Tour) overlay does not disappear after the window resizes → On boarding (Tour) overlay does not disappear after the window resizes or unloads
(Assignee)

Comment 4

9 months ago
Update the bug title again because in fact this is about the tour highlight/menu not the onboarding overlay(overlay did disappear)
Summary: On boarding (Tour) overlay does not disappear after the window resizes or unloads → On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads
Comment hidden (mozreview-request)
(Assignee)

Comment 6

9 months ago
mozreview-review
Comment on attachment 8900653 [details]
Bug 1388555 - On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads,

https://reviewboard.mozilla.org/r/172034/#review177348

::: browser/extensions/onboarding/content/onboarding.js:341
(Diff revision 1)
>      await this._loadCSS();
>      this._bundle = Services.strings.createBundle(BUNDLE_URI);
>  
>      this._loadJS(UITOUR_JS_URI);
>  
>      this._window.addEventListener("resize", this);

This will call `destroy` on unload then in turn disptach "Agent:Destroy" event to clean up UITour.

::: browser/extensions/onboarding/content/onboarding.js:345
(Diff revision 1)
>  
>      this._window.addEventListener("resize", this);
>  
>      // Destroy on unload. This is to ensure we remove all the stuff we left.
>      // No any leak out there.
>      this._window.addEventListener("unload", () => this.destroy());

This will call `destroy` on unload then in turn disptach "Agent:Destroy" event to clean up UITour.
(Assignee)

Comment 7

9 months ago
mozreview-review-reply
Comment on attachment 8900653 [details]
Bug 1388555 - On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads,

https://reviewboard.mozilla.org/r/172034/#review177348

> This will call `destroy` on unload then in turn disptach "Agent:Destroy" event to clean up UITour.

Sorry correct my self:
This will call destroy on resize then in turn disptach "Agent:Destroy" event to clean up UITour.
(Assignee)

Comment 8

9 months ago
(In reply to Fischer [:Fischer] from comment #5)
> Created attachment 8900653 [details]
> Bug 1388555 - On boarding (Tour) highlight/menu does not disappear after the
> window resizes or unloads,
> 
> Review commit: https://reviewboard.mozilla.org/r/172034/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/172034/
Hi Rex,
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ade7156c058e4acd3615e88ecfe4845ce4ea7e9
Thanks
(Assignee)

Updated

9 months ago
Attachment #8900653 - Flags: review?(rexboy)
Comment hidden (mozreview-request)

Comment 10

9 months ago
mozreview-review
Comment on attachment 8900653 [details]
Bug 1388555 - On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads,

https://reviewboard.mozilla.org/r/172034/#review178354

::: browser/extensions/onboarding/test/browser/browser_onboarding_tours.js:110
(Diff revision 2)
> +  let tab = await openTab(ABOUT_NEWTAB_URL);
> +  await promiseOnboardingOverlayLoaded(tab.linkedBrowser);
> +  await BrowserTestUtils.synthesizeMouseAtCenter("#onboarding-overlay-button", {}, tab.linkedBrowser);
> +  await promiseOnboardingOverlayOpened(tab.linkedBrowser);
> +
> +  // Trigger UITour showHighligh and showMenu

typo: showHighlight
Attachment #8900653 - Flags: review?(gasolin) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 12

9 months ago
mozreview-review-reply
Comment on attachment 8900653 [details]
Bug 1388555 - On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads,

https://reviewboard.mozilla.org/r/172034/#review178354

> typo: showHighlight

Fixed, thanks
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 13

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/75ae0405a90d
On boarding (Tour) highlight/menu does not disappear after the window resizes or unloads, r=gasolin
Keywords: checkin-needed

Comment 14

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/75ae0405a90d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Reporter)

Comment 15

9 months ago
Verified as fixed
Status: RESOLVED → VERIFIED
I have verified that the highlight/menu does disappear after the window resize on Win 10 x64, Win 7 x32, Ubuntu 16.04 x32, and Mac 10.12 with Firefox 58.
status-firefox57: fixed → verified
status-firefox58: --- → verified
You need to log in before you can comment on or make changes to this bug.