Closed Bug 1388563 Opened 7 years ago Closed 7 years ago

[iOS 11] Remove 'inout' argument from BrowserDB.withConnection<T>()

Categories

(Firefox for iOS :: Data Storage, enhancement, P2)

Product:
Firefox for iOS
Component:
Data Storage
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.30
Tracking Flags:
Tracking Status
fxios 10.0 ---

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [MobileCore][iOS11])

Attachments

(1 file)

GitHub Pull Request
55 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review
It seems as though our passing of `NSError` via `inout` is not making the Swift 4 compiler happy. Let's remove it and `throw` an error instead.
Blocks: ios11
Whiteboard: [MobileCore][iOS11]
Blocks: 1386494
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Iteration: --- → 1.28
tracking-fxios: --- → ?
Priority: -- → P1
Iteration: 1.28 → 1.29
Iteration: 1.29 → ---
tracking-fxios: ? → 10.0
Priority: P1 → P2
Iteration: --- → 1.30
Attached file GitHub Pull Request —
Attachment #8910306 - Flags: review?(rnewman)
Blocks: 1404087
Attachment #8910306 - Flags: review?(rnewman) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: