1388577 - Mac: Page Info window lacks a toolbar

Status: RESOLVED FIXED

(SeaMonkey :: Themes, enhancement)

Description

[Stefan [:stefanh]]

The description might be a bit misleading, but we want a unified toolbar look in the PageInfo window. I don't use PageInfo that much, but I noticed now that we lack a unified toolbar in the window... pageInfo.xul has a <windowdragbox> which currently is styled with '-moz-appearance: -moz-mac-unified-toolbar;", but that's obsolete since https://hg.mozilla.org/mozilla-central/rev/798a61cdcf78.

The trick is to use '-moz-appearance: toolbar;' instead.

Comment 1

[Stefan [:stefanh]]

Attachment: Restore unified toolbar look

One-liner, very simple.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8895178 [details] [diff] [review]
Restore unified toolbar look

Maybe put a reference to Bug 534170 in the comment. This is what actually removed the usage from Fx.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/15610850d580
Restore unified toolbar look in PageInfo window (Bug 534170 made '-moz-mac-unified-toolbar' obsolete). r=frg.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/41a1c8f12802
Restore unified toolbar look in PageInfo window (bug 1206468 made '-moz-mac-unified-toolbar' obsolete). r=frg.

Comment 5

[Stefan [:stefanh]]

Comment on attachment 8895178 [details] [diff] [review]
Restore unified toolbar look

[Approval Request Comment]
Regression caused by (bug #): bug 1206468
User impact if declined: unpolished PageInfo window
Testing completed (on m-c, etc.): nope
Risk to taking this patch (and alternatives if risky): no risk, simple css one-liner
String changes made by this patch: none

Comment 6

[Ian Neal]

Comment on attachment 8895178 [details] [diff] [review]
Restore unified toolbar look

a=me for c-b and c-esr

Comment 7

[Stefan [:stefanh]]

https://hg.mozilla.org/releases/comm-esr52/rev/2bd05ce71a70
https://hg.mozilla.org/releases/comm-beta/rev/1c8042a81862