1388604 - Move SetReadMode() from MediaResource to BaseMediaResource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The method is used by ChannelMediaResource only for cache management.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1388604 - move SetReadMode() from MediaResource to BaseMediaResource.

It would be less accurate to call SetReadMode(MediaCacheStream::MODE_PLAYBACK)
in ChannelMediaDecoder::MetadataLoaded() instead of DecodeMetadataState::OnMetadataRead()
because MDSM might have started decoding by the time 'metadata loaded' event arrives
in the main thread. However this little inaccuracy should be fine since it only
affects a small amount of data concerning the eviction algorithm.

Review commit: https://reviewboard.mozilla.org/r/166898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166898/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8895646 [details]
Bug 1388604 - move SetReadMode() from MediaResource to BaseMediaResource.

https://reviewboard.mozilla.org/r/166898/#review171994

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f72d68caf0d
move SetReadMode() from MediaResource to BaseMediaResource. r=gerald

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f72d68caf0d