bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Make sure mathml display items are unique

RESOLVED FIXED in Firefox 57

Status

()

Core
Layout: Web Painting
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow, NeedInfo)

Tracking

(Blocks: 1 bug)

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Created attachment 8895211 [details] [diff] [review]
fix-mathml-items

FrameLayerBuilder requires the the (frame,per-frame-key) for each display item is unique. It only enforces this in certain situations though, so there's cases where we've gotten away without this.

Retained display lists introduces more situations where we rely on this, so I've found a few.

MathML nsDisplayNotation and nsDisplayMathMLBar are the two fixed by this patch.

I seem to remember there being an important reason as to why I switched the enum over to EnumSet, but I've since forgotten it. It does look nice though!
Attachment #8895211 - Flags: review?(karlt)

Comment 1

11 months ago
Comment on attachment 8895211 [details] [diff] [review]
fix-mathml-items

Assuming the commit messages looks something like comment 0.

I like EnumSet.

>     NOTATION_LONGDIV = 0x1,
>-    NOTATION_RADICAL = 0x2,
>+    NOTATION_RADICAL,

Can we keep longdiv at bit 0, please?
i.e. remove the = 0x1.
Attachment #8895211 - Flags: review?(karlt) → review+

Comment 2

11 months ago
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b2edbf5944a
Make sure MathML display items are unique. r=karlt
Backed out the push with bug 1388614, bug 1388162 and bug 1388161:

bug 1388614: https://hg.mozilla.org/integration/mozilla-inbound/rev/97d71323c3f9a6b7d034a692ae2ad9cd489357f0
bug 1388162: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c4d5576374d3a4dd74945e7246576a8877dca79
bug 1388161: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0f5be3f9f5239098364712f31d7a80f3e10cd3b

Push with failures (all non-e10s?): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6b2edbf5944a1afbb8670920eae565e5543a735e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=122267227&repo=mozilla-inbound

[task 2017-08-10T12:19:28.831476Z] 12:19:28     INFO - TEST-START | dom/animation/test/chrome/test_animation_performance_warning.html
[task 2017-08-10T12:19:29.736537Z] 12:19:29     INFO - TEST-INFO | started process screentopng
[task 2017-08-10T12:19:30.035665Z] 12:19:30     INFO - TEST-INFO | screentopng: exit 0
[task 2017-08-10T12:19:30.037377Z] 12:19:30     INFO - Buffered messages logged at 12:19:29
[task 2017-08-10T12:19:30.038090Z] 12:19:30     INFO - TEST-PASS | dom/animation/test/chrome/test_animation_performance_warning.html | Bug 1196114 - Test metadata related to which animation properties are running on the compositor - Bug 1196114 - Test metadata related to which animation properties are running on the compositor: Elided 21 passes or known failures.
[task 2017-08-10T12:19:30.038143Z] 12:19:30     INFO - Buffered messages finished
[task 2017-08-10T12:19:30.038604Z] 12:19:30     INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/chrome/test_animation_performance_warning.html | preserve-3d transform - preserve-3d transform: assert_true: runningOnCompositor property should be true on transform expected true got false
Flags: needinfo?(matt.woodrow)

Comment 4

11 months ago
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61e9f34166f4
Make sure MathML display items are unique. r=karlt

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61e9f34166f4
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.