1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We still have two calls for the window manager mixin which state that those are necessary because close() doesn't wait. This is not true anymore since bug 1311350 has been fixed for Firefox 53.

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/runner/mixins/window_manager.py#44-48

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/runner/mixins/window_manager.py#65-69

Lets get those removed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin.

Given that both 'close' and 'close_chrome_window' wait for the underlying
tab or window to be closed, there is not need to explicitely wait in tests.

Review commit: https://reviewboard.mozilla.org/r/166458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166458/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1388627 - close_chrome_window always operates in chrome context.

Review commit: https://reviewboard.mozilla.org/r/166468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166468/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8895280 [details]
Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin.

https://reviewboard.mozilla.org/r/166458/#review172388

Comment 4

[David Burns :automatedtester]

Comment on attachment 8895281 [details]
Bug 1388627 - close_chrome_window always operates in chrome context.

https://reviewboard.mozilla.org/r/166468/#review172390

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6f14ea1dbe3
Remove obsolete Wait.until() calls from Window Manager Mixin. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/77865d6f19c1
close_chrome_window always operates in chrome context. r=automatedtester

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e6f14ea1dbe3
https://hg.mozilla.org/mozilla-central/rev/77865d6f19c1