Closed
Bug 1388631
Opened 7 years ago
Closed 7 years ago
defineLazyPreferenceGetter is too slow
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
It calls generateQI to generate a new QueryInterface function for every call, which adds up fast.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895234 [details] Bug 1388631: Don't call generateQI for every defineLazyPreferenceGetter call. https://reviewboard.mozilla.org/r/166388/#review171734
Attachment #8895234 -
Flags: review?(mixedpuppy) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/440697b45d73109f868c88fbf39df32ee29c6d47 Bug 1388631: Don't call generateQI for every defineLazyPreferenceGetter call. r=mixedpuppy
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/440697b45d73
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•