defineLazyPreferenceGetter is too slow

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
WebExtensions: General
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

It calls generateQI to generate a new QueryInterface function for every call, which adds up fast.
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8895234 [details]
Bug 1388631: Don't call generateQI for every defineLazyPreferenceGetter call.

https://reviewboard.mozilla.org/r/166388/#review171734
Attachment #8895234 - Flags: review?(mixedpuppy) → review+

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/440697b45d73
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.