Closed Bug 1388638 Opened 7 years ago Closed 7 years ago

Use RAII class for StartBatchChanges/EndBatchChanges

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

CompositionTransaction forgets calling EndBatchChanges when GetSelectionController returns error, so we should use RAII class instead.
Comment on attachment 8895652 [details]
Bug 1388638 - Use RAII class for StartBatchChanges/EndBatchChanges.

https://reviewboard.mozilla.org/r/166486/#review172072
Attachment #8895652 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/a072bd6e8ad7
Use RAII class for StartBatchChanges/EndBatchChanges. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/a072bd6e8ad7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: