Closed Bug 1388665 Opened 3 years ago Closed 3 years ago

Remove BufferingState::DispatchDecodeTasksIfNeeded()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

The function is called in BufferingState::Step() [1] to dispatch decoding tasks when necessary. We should do the dispatching in Handle{Audio,Video}Decoded [2] for some checks won't be necessary and the logic can be simplified.

E.g. In HandleAudioDecoded() we are guaranteed to have:
1. mMaster->IsAudioDecoding() is true
2. mMaster->IsRequestingAudioData() is false
3. mMaster->IsWaitingAudioData() is false


[1] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/dom/media/MediaDecoderStateMachine.cpp#2594,2598
[2] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/dom/media/MediaDecoderStateMachine.cpp#1877,1885
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
Attachment #8895649 - Flags: review?(kaku)
Comment on attachment 8895649 [details]
Bug 1388665 - remove BufferingState::DispatchDecodeTasksIfNeeded().

https://reviewboard.mozilla.org/r/166908/#review172016
Attachment #8895649 - Flags: review?(kaku) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c879d5173d1
remove BufferingState::DispatchDecodeTasksIfNeeded(). r=kaku
https://hg.mozilla.org/mozilla-central/rev/4c879d5173d1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.