1388665 - Remove BufferingState::DispatchDecodeTasksIfNeeded()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The function is called in BufferingState::Step() [1] to dispatch decoding tasks when necessary. We should do the dispatching in Handle{Audio,Video}Decoded [2] for some checks won't be necessary and the logic can be simplified.

E.g. In HandleAudioDecoded() we are guaranteed to have:
1. mMaster->IsAudioDecoding() is true
2. mMaster->IsRequestingAudioData() is false
3. mMaster->IsWaitingAudioData() is false


[1] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/dom/media/MediaDecoderStateMachine.cpp#2594,2598
[2] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/dom/media/MediaDecoderStateMachine.cpp#1877,1885

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1388665 - remove BufferingState::DispatchDecodeTasksIfNeeded().

We will dispatch decoding tasks in Handle{Audio,Video}Decoded() instead.
See comment 0 for the rationale.

Review commit: https://reviewboard.mozilla.org/r/166908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166908/

Comment 2

[Tzuhao Kuo [:kaku]]

Comment on attachment 8895649 [details]
Bug 1388665 - remove BufferingState::DispatchDecodeTasksIfNeeded().

https://reviewboard.mozilla.org/r/166908/#review172016

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c879d5173d1
remove BufferingState::DispatchDecodeTasksIfNeeded(). r=kaku

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c879d5173d1