RCWN breaks HTTP_CHANNEL_DISPOSITION telemetry

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: michal, Assigned: michal)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When racing cache with network mUsedNetwork is always true. Should we report value according to who wins or should we add new values?

Btw, the current code reports kHttpNetOK when we revalidate the cache entry with server and use the cached content. Is this OK?
(Assignee)

Updated

2 years ago
Flags: needinfo?(mcmanus)
(In reply to Michal Novotny (:michal) from comment #0)
> When racing cache with network mUsedNetwork is always true. Should we report
> value according to who wins or should we add new values?

according to who wins

> 
> Btw, the current code reports kHttpNetOK when we revalidate the cache entry
> with server and use the cached content. Is this OK?

yeah that's the right thing. The transaction required the network and it went ok.
Flags: needinfo?(mcmanus)
(Assignee)

Comment 2

2 years ago
Posted patch fixSplinter Review
Assignee: nobody → michal.novotny
Attachment #8897043 - Flags: review?(mcmanus)
(Assignee)

Updated

2 years ago
Whiteboard: [necko-active]
Attachment #8897043 - Flags: review?(mcmanus) → review+

Comment 3

2 years ago
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05448985c4cb
RCWN breaks HTTP_CHANNEL_DISPOSITION telemetry, r=mcmanus

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05448985c4cb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.