Closed Bug 13887 Opened 24 years ago Closed 24 years ago

[dogfood] in composer, editor never gets a Focus notification

Categories

(Core :: DOM: Editor, defect, P1)

x86
Windows NT
defect

Tracking

()

VERIFIED DUPLICATE of bug 9701

People

(Reporter: buster, Assigned: hyatt)

References

()

Details

(Whiteboard: [PDT-])

launch editor from browser task menu, so default edit page loads
notice the caret, it's above the first line of text and really small
the selection at this point is Sel. Collapse to 031F90AC __moz_text 0 according
to debug output (turning on DEBUG_SELECTION in nsRangeList.cpp)
Priority: P3 → P1
Target Milestone: M11
Status: NEW → ASSIGNED
This is because the caret is in a text node which contains just whitespace. I
think the code that sets the initial selection for the editor needs to be a bit
smarter.
Could someone point me at the code where this might be addressed?
Assignee: sfraser → buster
Status: ASSIGNED → NEW
Reassigning this, due to current focus on performance issues.
Steve, IsEditable needs to return true for <BR> nodes/frames, so that the caret
ends up being placed on the first one. What happens now, in mail compose, is that
the caret ends up in the signature, because that's the first node that contains
text.
Status: NEW → ASSIGNED
Summary: caret in odd place when editor launched → [blocker] caret in odd place when editor launched
Whiteboard: fix in hand, waiting for permission
Target Milestone: M11 → M10
this looks like a usability blocker, quite easy to fix, very low risk.  simon
has already code reviewed.
ok.  checkin. thanks
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, waiting for permission
fixed, a=chofmann, r=sfraser
Status: RESOLVED → REOPENED
I don't see any carat when launching editor....reopening this one...
Resolution: FIXED → ---
Clearing Fixed resolution due to reopen.
Using the 19999100618 M10 candidate commercial build on NT, I'm seeing the caret
appear initially before the "H", and then disappear.

User must click in document in order for the caret to reappear.
Target Milestone: M10 → M11
Moving to M11.  sujay, please Release Note for M10 at:
http://bugzilla.mozilla.org/show_bug.cgi?id=14872
I think this is simply the content area failing to get focus.  Selection is set
in the correct place in the document.
Summary: [blocker] caret in odd place when editor launched → [dogfood] caret in odd place when editor launched
marking dogfood, because it makes the app a pain to use.  removing blocker,
since no one is actually blocked on this. Sent a note to simon, hyatt, and pink
asking about focus.
Summary: [dogfood] caret in odd place when editor launched → [dogfood-pd-] caret in odd place when editor launched
Not a dogfood blocker.  sorry...adding pdt-
Summary: [dogfood-pd-] caret in odd place when editor launched → [dogfood][pd-]caret in odd place when editor launched
Summary: [dogfood][pd-]caret in odd place when editor launched → [dogfood][PDT-]caret in odd place when editor launched
Summary: [dogfood][PDT-]caret in odd place when editor launched → [dogfood]caret in odd place when editor launched
Whiteboard: [PDT-]
Assignee: buster → hyatt
Status: REOPENED → NEW
Summary: [dogfood]caret in odd place when editor launched → [dogfood] in composer, editor never gets a Focus notification
with recent focus change landings, I think this got broken.  The problem is the
editor never gets a focus message.  Set a break in
nsTextEditorFocusListener::Focus(nsIDOMEvent* aEvent),
run apprunner -edit
editor focus handler never gets called.  It used to, it still should.
Blocks: 16654
Status: NEW → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → DUPLICATE
*** This bug has been marked as a duplicate of 9701 ***
Status: RESOLVED → VERIFIED
verified in 10/22 build.
You need to log in before you can comment on or make changes to this bug.