13887 - [dogfood] in composer, editor never gets a Focus notification

Status: VERIFIED DUPLICATE of bug 9701

(Core :: DOM: Editor, defect, P1)

Description

[buster]

launch editor from browser task menu, so default edit page loads
notice the caret, it's above the first line of text and really small
the selection at this point is Sel. Collapse to 031F90AC __moz_text 0 according
to debug output (turning on DEBUG_SELECTION in nsRangeList.cpp)

Comment 1

[Simon Fraser [no longer active]]

This is because the caret is in a text node which contains just whitespace. I
think the code that sets the initial selection for the editor needs to be a bit
smarter.

Comment 2

[Simon Fraser [no longer active]]

Could someone point me at the code where this might be addressed?

Comment 3

[Simon Fraser [no longer active]]

Reassigning this, due to current focus on performance issues.
Steve, IsEditable needs to return true for <BR> nodes/frames, so that the caret
ends up being placed on the first one. What happens now, in mail compose, is that
the caret ends up in the signature, because that's the first node that contains
text.

Comment 4

[buster]

this looks like a usability blocker, quite easy to fix, very low risk.  simon
has already code reviewed.

Comment 5

[chris hofmann]

ok.  checkin. thanks

Comment 6

[buster]

fixed, a=chofmann, r=sfraser

Comment 7

[sujay]

I don't see any carat when launching editor....reopening this one...

Comment 8

[leger]

Clearing Fixed resolution due to reopen.

Comment 9

[Eli Goldberg]

Using the 19999100618 M10 candidate commercial build on NT, I'm seeing the caret
appear initially before the "H", and then disappear.

User must click in document in order for the caret to reappear.

Comment 10

[leger]

Moving to M11.  sujay, please Release Note for M10 at:
http://bugzilla.mozilla.org/show_bug.cgi?id=14872

Comment 11

[buster]

I think this is simply the content area failing to get focus.  Selection is set
in the correct place in the document.

Comment 12

[buster]

marking dogfood, because it makes the app a pain to use.  removing blocker,
since no one is actually blocked on this. Sent a note to simon, hyatt, and pink
asking about focus.

Comment 13

[leger]

Not a dogfood blocker.  sorry...adding pdt-

Comment 14

[buster]

with recent focus change landings, I think this got broken.  The problem is the
editor never gets a focus message.  Set a break in
nsTextEditorFocusListener::Focus(nsIDOMEvent* aEvent),
run apprunner -edit
editor focus handler never gets called.  It used to, it still should.

Comment 15

[Peter Trudelle]

*** This bug has been marked as a duplicate of 9701 ***

Comment 16

[sujay]

verified in 10/22 build.