CustomTab: doorhanger not displayed

VERIFIED FIXED in Firefox 57

Status

()

Firefox for Android
General
VERIFIED FIXED
10 months ago
7 months ago

People

(Reporter: sorina, Assigned: jchen)

Tracking

(Blocks: 2 bugs)

57 Branch
Firefox 57
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

(Reporter)

Description

10 months ago
Environment: 
Device: HTC 10 (Android 7.0);
Build: Nightly 57.0a1 (2017-08-09);
Prerequisites: enable Custom tabs in settings.

Steps to reproduce:
1. Go to https://mozilla.github.io/webrtc-landing/gum_test_aec.html from Gmail app;
2. Tap on Audio&video.

Expected result:
A doorhanger is displayed asking to share the microphone and camera.

Actual result:
No doorhanger is displayed.

Notes:
Reproducible also for Facebook login when saving passwords, geolocation etc.
Blocks: 1208655
No longer blocks: 1356346
tracking-fennec: ? → +
(Assignee)

Updated

9 months ago
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

9 months ago
mozreview-review
Comment on attachment 8898549 [details]
Bug 1388724 - 5. Make RuntimePermissions not depend on GeckoApp;

https://reviewboard.mozilla.org/r/169918/#review175198

Nice!
Attachment #8898549 - Flags: review?(s.kaspari) → review+

Comment 8

9 months ago
mozreview-review
Comment on attachment 8898545 [details]
Bug 1388724 - 1. Support non-GeckoApp context in DoorHangerPopup;

https://reviewboard.mozilla.org/r/169910/#review175218
Attachment #8898545 - Flags: review?(cnevinchen) → review+

Comment 9

9 months ago
mozreview-review
Comment on attachment 8898548 [details]
Bug 1388724 - 4. Use universal doorhanger API for content permissions;

https://reviewboard.mozilla.org/r/169916/#review175290
Attachment #8898548 - Flags: review?(esawin) → review+

Comment 10

9 months ago
mozreview-review
Comment on attachment 8898550 [details]
Bug 1388724 - 6. Make WebrtcUI not depend on browser.js;

https://reviewboard.mozilla.org/r/169920/#review175292

::: mobile/android/components/BrowserCLH.js:51
(Diff revision 1)
> +      XPCOMUtils.defineLazyGetter(this, name, _ => {
> +        let sandbox = {};
> +        Services.scriptloader.loadSubScript(script, sandbox);
> +        return sandbox[name];
> +      });
> +      let observer = (s, t, d) => {

Please use more descriptive argument names.
Attachment #8898550 - Flags: review?(esawin) → review+

Comment 11

9 months ago
mozreview-review
Comment on attachment 8898546 [details]
Bug 1388724 - 2. Add universal DoorHanger API;

https://reviewboard.mozilla.org/r/169912/#review175394
Attachment #8898546 - Flags: review?(droeh) → review+

Comment 12

9 months ago
mozreview-review
Comment on attachment 8898547 [details]
Bug 1388724 - 3. Add DoorHangerPopup to custom tabs and PWA;

https://reviewboard.mozilla.org/r/169914/#review175398
Attachment #8898547 - Flags: review?(droeh) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 19

9 months ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7d586922755
1. Support non-GeckoApp context in DoorHangerPopup; r=nechen
https://hg.mozilla.org/integration/autoland/rev/8cd05b219a9e
2. Add universal DoorHanger API; r=droeh
https://hg.mozilla.org/integration/autoland/rev/a5a657c11f0c
3. Add DoorHangerPopup to custom tabs and PWA; r=droeh
https://hg.mozilla.org/integration/autoland/rev/485647b7e806
4. Use universal doorhanger API for content permissions; r=esawin
https://hg.mozilla.org/integration/autoland/rev/a412eff66510
5. Make RuntimePermissions not depend on GeckoApp; r=sebastian
https://hg.mozilla.org/integration/autoland/rev/ed85d72cb6dd
6. Make WebrtcUI not depend on browser.js; r=esawin
(Assignee)

Updated

9 months ago
Duplicate of this bug: 1346694
status-firefox55: --- → unaffected
status-firefox56: --- → unaffected

Comment 22

9 months ago
Hi Jim.
Sorry I forgot to mention this. 
Maybe you'd like to show the background of DoorHanger like this bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1352004

btw,
I used Dale's test site to test custom tab features. https://daleharvey.github.io/testapp/ . Maybe you already knew.
Flags: needinfo?(nchen)

Comment 23

9 months ago
Oh, CustomTabsActivity and WebAppActivity were similar at that time. But I'm not sure if it still the case now. Maybe that site won't help here. If the design now is different, please ignore it :)
(Assignee)

Comment 24

9 months ago
Yeah we don't have the overlay for doorhangers in custom tabs / PWA. We can add that in a followup bug.
Flags: needinfo?(nchen)
(Assignee)

Updated

9 months ago
Blocks: 1393508
(Reporter)

Comment 25

7 months ago
Verified as fixed in build 57.0b9.
Devices: Motorola Nexus 6 (Android 7.1.1) and Sony Xperia Z5 Premium (Android 6.0.1).
Doorhanger is displayed following the steps from description and also for login page, geolocation.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.