Closed Bug 1388724 Opened 7 years ago Closed 7 years ago

CustomTab: doorhanger not displayed

Tracking

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Status:

VERIFIED FIXED

Milestone:

Firefox 57

Tracking Flags:

Tracking

Status

fennec

---

firefox55

---

unaffected

firefox56

---

unaffected

firefox57

---

verified

People

(Reporter: sflorean, Assigned: jchen)

References

Details

Attachments

(6 files)

Bug 1388724 - 1. Support non-GeckoApp context in DoorHangerPopup; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	cnevinchen : review+	Details
Bug 1388724 - 2. Add universal DoorHanger API; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	droeh : review+	Details
Bug 1388724 - 3. Add DoorHangerPopup to custom tabs and PWA; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	droeh : review+	Details
Bug 1388724 - 4. Use universal doorhanger API for content permissions; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	esawin : review+	Details
Bug 1388724 - 5. Make RuntimePermissions not depend on GeckoApp; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	sebastian : review+	Details
Bug 1388724 - 6. Make WebrtcUI not depend on browser.js; 7 years ago (inactive) Jim Chen [:jchen] [:darchons] 59 bytes, text/x-review-board-request	esawin : review+	Details

Sorina Florean [:sflorean]

Reporter

Description

•

7 years ago

Environment: 
Device: HTC 10 (Android 7.0);
Build: Nightly 57.0a1 (2017-08-09);
Prerequisites: enable Custom tabs in settings.

Steps to reproduce:
1. Go to https://mozilla.github.io/webrtc-landing/gum_test_aec.html from Gmail app;
2. Tap on Audio&video.

Expected result:
A doorhanger is displayed asking to share the microphone and camera.

Actual result:
No doorhanger is displayed.

Notes:
Reproducible also for Facebook login when saving passwords, geolocation etc.

James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)

Updated

•

7 years ago

Blocks: customtabs
No longer blocks: customtabs_geckoview

tracking-fennec: ? → +

(inactive) Jim Chen [:jchen] [:darchons]

Assignee

Updated

•

7 years ago

Assignee: nobody → nchen

Status: NEW → ASSIGNED

Comment hidden (mozreview-request)

Make DoorHangerPopup support being used from non-GeckoApp contexts, so
we can reuse it from custom tabs and PWA.

Review commit: https://reviewboard.mozilla.org/r/169910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169910/

Comment hidden (mozreview-request)

Add a DoorHanger API that doesn't rely on browser.js/NativeWindow, so we
can use doorhangers for custom tabs and PWA. The API falls back to the
old NativeWindow implementation when dealing with the brower.js window.

Review commit: https://reviewboard.mozilla.org/r/169912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169912/

Comment hidden (mozreview-request)

Add a DoorHangerPopup to CustomTabsActivity and WebAppActivity, so we
can show doorhangers for custom tabs and PWA.

Review commit: https://reviewboard.mozilla.org/r/169914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169914/

Comment hidden (mozreview-request)

Use the new universal doorhanger API for showing content permissions
like geolocation.

Review commit: https://reviewboard.mozilla.org/r/169916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169916/

Comment hidden (mozreview-request)

Move the check permission event from `GeckoApp` to `GeckoApplication`,
and use the current activity if possible, so that we can use
`RuntimePermissions` in custom tabs and PWA. Also implement
`onRequestPermissionsResult` for custom tabs and PWA, in order to
forward the result back to `RuntimePermissions`.

Review commit: https://reviewboard.mozilla.org/r/169918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169918/

Comment hidden (mozreview-request)

Move WebrtcUI loading from browser.js to BrowserCLH.js, so that it can
be loaded without GeckoApp/browser.js being active. Also use the
universal doorhanger API to show the prompts.

Review commit: https://reviewboard.mozilla.org/r/169920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169920/

Sebastian Kaspari (:sebastian; :pocmo)

Comment 7

•

7 years ago

mozreview-review

Comment on attachment 8898549 [details]
Bug 1388724 - 5. Make RuntimePermissions not depend on GeckoApp;

https://reviewboard.mozilla.org/r/169918/#review175198

Nice!

Attachment #8898549 - Flags: review?(s.kaspari) → review+

Nevin Chen(Not active on Bugzilla)

Comment 8

•

7 years ago

mozreview-review

Comment on attachment 8898545 [details]
Bug 1388724 - 1. Support non-GeckoApp context in DoorHangerPopup;

https://reviewboard.mozilla.org/r/169910/#review175218

Attachment #8898545 - Flags: review?(cnevinchen) → review+

Eugen Sawin [:esawin]

Comment 9

•

7 years ago

mozreview-review

Comment on attachment 8898548 [details]
Bug 1388724 - 4. Use universal doorhanger API for content permissions;

https://reviewboard.mozilla.org/r/169916/#review175290

Attachment #8898548 - Flags: review?(esawin) → review+

Eugen Sawin [:esawin]

Comment 10

•

7 years ago

mozreview-review

Comment on attachment 8898550 [details]
Bug 1388724 - 6. Make WebrtcUI not depend on browser.js;

https://reviewboard.mozilla.org/r/169920/#review175292

::: mobile/android/components/BrowserCLH.js:51
(Diff revision 1)
> +      XPCOMUtils.defineLazyGetter(this, name, _ => {
> +        let sandbox = {};
> +        Services.scriptloader.loadSubScript(script, sandbox);
> +        return sandbox[name];
> +      });
> +      let observer = (s, t, d) => {

Please use more descriptive argument names.

Attachment #8898550 - Flags: review?(esawin) → review+

Dylan Roeh (:droeh) (he/him)

Comment 11

•

7 years ago

mozreview-review

Comment on attachment 8898546 [details]
Bug 1388724 - 2. Add universal DoorHanger API;

https://reviewboard.mozilla.org/r/169912/#review175394

Attachment #8898546 - Flags: review?(droeh) → review+

Dylan Roeh (:droeh) (he/him)

Comment 12

•

7 years ago

mozreview-review

Comment on attachment 8898547 [details]
Bug 1388724 - 3. Add DoorHangerPopup to custom tabs and PWA;

https://reviewboard.mozilla.org/r/169914/#review175398

Attachment #8898547 - Flags: review?(droeh) → review+

Comment hidden (mozreview-request)

Comment on attachment 8898545 [details]
Bug 1388724 - 1. Support non-GeckoApp context in DoorHangerPopup;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169910/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8898546 [details]
Bug 1388724 - 2. Add universal DoorHanger API;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169912/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8898547 [details]
Bug 1388724 - 3. Add DoorHangerPopup to custom tabs and PWA;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169914/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8898548 [details]
Bug 1388724 - 4. Use universal doorhanger API for content permissions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169916/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8898549 [details]
Bug 1388724 - 5. Make RuntimePermissions not depend on GeckoApp;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169918/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8898550 [details]
Bug 1388724 - 6. Make WebrtcUI not depend on browser.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169920/diff/1-2/

Pulsebot

Comment 19

•

7 years ago

Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7d586922755
1. Support non-GeckoApp context in DoorHangerPopup; r=nechen
https://hg.mozilla.org/integration/autoland/rev/8cd05b219a9e
2. Add universal DoorHanger API; r=droeh
https://hg.mozilla.org/integration/autoland/rev/a5a657c11f0c
3. Add DoorHangerPopup to custom tabs and PWA; r=droeh
https://hg.mozilla.org/integration/autoland/rev/485647b7e806
4. Use universal doorhanger API for content permissions; r=esawin
https://hg.mozilla.org/integration/autoland/rev/a412eff66510
5. Make RuntimePermissions not depend on GeckoApp; r=sebastian
https://hg.mozilla.org/integration/autoland/rev/ed85d72cb6dd
6. Make WebrtcUI not depend on browser.js; r=esawin

Phil Ringnalda (:philor)

Comment 20

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a7d586922755
https://hg.mozilla.org/mozilla-central/rev/8cd05b219a9e
https://hg.mozilla.org/mozilla-central/rev/a5a657c11f0c
https://hg.mozilla.org/mozilla-central/rev/485647b7e806
https://hg.mozilla.org/mozilla-central/rev/a412eff66510
https://hg.mozilla.org/mozilla-central/rev/ed85d72cb6dd

Status: ASSIGNED → RESOLVED

Closed: 7 years ago

status-firefox57: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 57

Ryan VanderMeulen [:RyanVM]

Updated

•

7 years ago

status-firefox55: --- → unaffected

status-firefox56: --- → unaffected

Nevin Chen(Not active on Bugzilla)

Comment 22

•

7 years ago

Hi Jim.
Sorry I forgot to mention this. 
Maybe you'd like to show the background of DoorHanger like this bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1352004

btw,
I used Dale's test site to test custom tab features. https://daleharvey.github.io/testapp/ . Maybe you already knew.

Flags: needinfo?(nchen)

Nevin Chen(Not active on Bugzilla)

Comment 23

•

7 years ago

Oh, CustomTabsActivity and WebAppActivity were similar at that time. But I'm not sure if it still the case now. Maybe that site won't help here. If the design now is different, please ignore it :)

(inactive) Jim Chen [:jchen] [:darchons]

Assignee

Comment 24

•

7 years ago

Yeah we don't have the overlay for doorhangers in custom tabs / PWA. We can add that in a followup bug.

Flags: needinfo?(nchen)

(inactive) Jim Chen [:jchen] [:darchons]

Assignee

Updated

•

7 years ago

Blocks: 1393508

Sorina Florean [:sflorean]

Reporter

Comment 25

•

7 years ago

Verified as fixed in build 57.0b9.
Devices: Motorola Nexus 6 (Android 7.1.1) and Sony Xperia Z5 Premium (Android 6.0.1).
Doorhanger is displayed following the steps from description and also for login page, geolocation.

Status: RESOLVED → VERIFIED

status-firefox57: fixed → verified

Nobody; OK to take it and work on it

Updated

•

3 years ago

Product: Firefox for Android → Firefox for Android Graveyard

You need to log in before you can comment on or make changes to this bug.