1388744 - curl header issue on 64bit sparc

Status: RESOLVED DUPLICATE of bug 1411516

(Firefox Build System :: General, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170713232506

Steps to reproduce:

S12-ul-cbe 14:30 /scratch/firefox/obj-sparc64-sun-solaris2.12/toolkit/components/telemetry/pingsender: /usr/bin/g++ -std=gnu++11 -o Unified_cpp_pingsender0.o -c  -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/system_wrappers -include /scratch/firefox/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -I/scratch/firefox/toolkit/components/telemetry/pingsender -I/scratch/firefox/obj-sparc64-sun-solaris2.12/toolkit/components/telemetry/pingsender -I/scratch/firefox/toolkit/crashreporter/google-breakpad/src -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include  -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nspr -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /scratch/firefox/obj-sparc64-sun-solaris2.12/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_pingsender0.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O -fno-omit-frame-pointer     /scratch/firefox/obj-sparc64-sun-solaris2.12/toolkit/components/telemetry/pingsender/Unified_cpp_pingsender0.cpp
In file included from /scratch/firefox/toolkit/crashreporter/google-breakpad/src/third_party/curl/curl.h:44:0,
                 from /scratch/firefox/toolkit/components/telemetry/pingsender/pingsender_unix_common.cpp:13,
                 from /scratch/firefox/obj-sparc64-sun-solaris2.12/toolkit/components/telemetry/pingsender/Unified_cpp_pingsender0.cpp:11:
/scratch/firefox/toolkit/crashreporter/google-breakpad/src/third_party/curl/curlrules.h:144:41: error: size of array '__curl_rule_01__' is negative
     [CurlchkszEQ(long, CURL_SIZEOF_LONG)];
                                         ^

Comment 1

[Petr Sumbera]

Attachment: Bug1388744.patch

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8895385 [details] [diff] [review]
Bug1388744.patch

Review of attachment 8895385 [details] [diff] [review]:
-----------------------------------------------------------------

The problem here is that this is third-party code, and HAVE_64BIT_BUILD is a gecko-specific thing. However, considering the state of breakpad, we may accept the patch this way, but that'd be for ted to decide.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8895385 [details] [diff] [review]
Bug1388744.patch

Review of attachment 8895385 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need to fix this upstream in Breakpad:
https://chromium.googlesource.com/breakpad/breakpad/+/master/#to-request-change-review

It looks like this file was originally taken from libcurl, but I think it's been patched locally in the Breakpad repo at this point.

Comment 4

[Petr Sumbera]

Reported upstream via:
https://bugs.chromium.org/p/google-breakpad/issues/detail?id=742

Comment 6

[Jan Beich]

Can you still reproduce after bug 1411516 fix? It uses defined(__LP64__) as a fallback.

Comment 7

[Petr Sumbera]

No. The issue is now resolved via bug 1411516.