1388756 - The js::oom flags are now used for more than oom, so clean up

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Lars T Hansen [:lth]]

See bug 1379814 comment 9 for context.  We should move the thread identifiers out of the js::oom namespace because they are generally useful and we use them for more than just OOM.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1388756-expose-thread-types.patch

This moves the ThreadType from js::oom:: to js::, by shifting a little code in public/Utility.h, then cleans up all qualified references to omit the oom::.

I left the InitThreadType et al in the oom namespace since they really are no-ops except in certain testing modes, while the ThreadType is now used more generally.

Note, this sits on top of the pending patch for bug 1379814.

Compile-only try run is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f36007198f91dbcfdd2e1b368f76719f6ffe91b

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04f4df930678
Move helper thread types out of the OOM namespace. r=jonco

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04f4df930678